Re: [PATCH] ntdll: provide a timestamp debug channel, which prints a millisecond resolution timestamp in front of debug output, very useful to debug deadlocks (resend)

[Alexandre Julliard]

Bernhard Loos <bernhardloos(a)googlemail.com> writes:
> @@ -164,8 +165,16 @@ static int NTDLL_dbg_vlog( enum __wine_debug_class cls, struct __wine_debug_chan
>      /* only print header if we are at the beginning of the line */
>      if (info->out_pos == info->output || info->out_pos[-1] == '\n')
>      {
> +        if (TRACE_ON(timestamp))
> +        {
> +            LARGE_INTEGER now;
> +            extern timeout_t server_start_time;

Don't add extern statements all over the place, there are functions to
return tick counts. Also you probably want a more readable formatting.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH] ntdll: provide a timestamp debug channel, which prints a millisecond resolution timestamp in front of debug output, very useful to debug deadlocks (resend)

[Bernhard Loos]

On Wed, Aug 31, 2011 at 12:20 PM, Alexandre Julliard
<julliard(a)winehq.org> wrote:
> Bernhard Loos <bernhardloos(a)googlemail.com> writes:
> > @@ -164,8 +165,16 @@ static int NTDLL_dbg_vlog( enum __wine_debug_class cls, struct __wine_debug_chan
> >      /* only print header if we are at the beginning of the line */
> >      if (info->out_pos == info->output || info->out_pos[-1] == '\n')
> >      {
> > +        if (TRACE_ON(timestamp))
> > +        {
> > +            LARGE_INTEGER now;
> > +            extern timeout_t server_start_time;
>
> Don't add extern statements all over the place, there are functions to
> return tick counts.
> Found NtGetTickCount, after some looking around which does what I need.
> In my defence, I the kernel32 version of GetTickCount also calls
> NtQuerySystemTime, so it never occured to me, that there might be one
> in ntdll.
> Also you probably want a more readable formatting.
> I'm not exactly sure, how to make it more readable. I could add a .
> after seconds and ms at the end, but this makes it more likely to
> create line wraps, which also hurts readability and it's not that hard
> to figure out.
> --
> Alexandre Julliard
> julliard(a)winehq.org