Re: listview: infoPtr might be invalid after WM_NOTIFY

[Robert Shearman]

Michael Jung wrote:
> Hello Alexandre, Dimi and Phil,
>
> This is a patch for the infoPtr problem in comctl32's listview.c. I guess it 
> matches your suggestion on IRC? I've only changed the minimum necessary to 
> get rid of the file dialog crash. If that's the correct approach in your 
> opinion, I will continue to work on this. I will be on vacation for three 
> weeks, though, starting from Friday.
>
> Dimi, if you think this is ugly, or if you are working on a better solution, 
> please do protest.
>
> Changelog:
>   infoPtr might be invalid after a WM_NOTIFY message was sent, since the 
> application might have destroyed the listview. Pass around hwnd instead and 
> call GetWindowLongPtr, if we have to access the listview instance data. 
> Spotted by Phil Krylov.

Since this was a behaviour in our file open dialog, did we even verify 
that this was a listview bug or is it that destroying the listview in 
the middle of a notification is something that you shouldn't do? If the 
latter, then one could easily modify the file dialog to post a message 
to itself to destroy the listview after the listview has finished 
processing the message that caused the notification.

-- 
Rob Shearman

listview: infoPtr might be invalid after WM_NOTIFY

[Phil Krylov]

On Tue, 20 Sep 2005 16:20:50 -0500
Robert Shearman <rob(a)codeweavers.com> wrote:
> Since this was a behaviour in our file open dialog, did we even verify 
> that this was a listview bug or is it that destroying the listview in 
> the middle of a notification is something that you shouldn't do?

The native file dialog acts the same way.

-- Ph.

listview: infoPtr might be invalid after WM_NOTIFY

[Michael Jung]

Hi all,

I've scanned wine-devel and wine-patches and have seen that more patches got 
in to fix the file dialog crash, but that none was applied. Was there any 
consensus on how this should be fixed?

Bye,
-- 
Michael Jung
mjung(a)iss.tu-darmstadt.de

listview: infoPtr might be invalid after WM_NOTIFY

[Ulrich Czekalla]

On Tue, Sep 20, 2005 at 04:20:50PM -0500, Robert Shearman wrote:
> Since this was a behaviour in our file open dialog, did we even verify 
> that this was a listview bug or is it that destroying the listview in 
> the middle of a notification is something that you shouldn't do? If the \

A quick test under Windows doesn't present a problem when destroying the
listview inside one of its notifications.

/Ulrich