Re: ntdll: Try application manifest path when searching for dependent assemblies
10 Sep
2013
10 Sep
'13
3:10 p.m.
Nikolay Sivov <nsivov(a)codeweavers.com> writes:
@@ -2776,8 +2776,7 @@ static NTSTATUS lookup_assembly(struct actctx_loader* acl, /* FIXME: add support for language specific lookup */
nameW.Buffer = NULL; - if (!(buffer = RtlAllocateHeap( GetProcessHeap(), 0, - (strlenW(acl->actctx->appdir.info) + 2 * strlenW(ai->name) + 2) * sizeof(WCHAR) + sizeof(dotManifestW) ))) + if (!(buffer = RtlAllocateHeap( GetProcessHeap(), 0, MAX_PATH * sizeof(WCHAR) )))
Please try to allocate the correct size. If you want to use MAX_PATH you then have to check for overflow when building the string, which is probably worse. -- Alexandre Julliard julliard(a)winehq.org
4480
Age (days ago)
4480
Last active (days ago)
0 comments
1 participants
participants (1)
-
Alexandre Julliard