[PATCH v2 1/4] kernelbase: Use the same HLOCAL entry pointer alignment as native.
This changes the GlobalUnlock todo_wine as we previously considered the invalid mem handle as a valid pointer, and we now instead check handle validity. Returning TRUE in for an invalid handle doesn't seem very important, and a corner case, and it breaks compatibility and imm32 tests. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/kernel32/heap.c | 10 ++++------ dlls/kernel32/tests/heap.c | 17 +---------------- dlls/kernelbase/memory.c | 10 ++++------ 3 files changed, 9 insertions(+), 28 deletions(-) diff --git a/dlls/kernel32/heap.c b/dlls/kernel32/heap.c index dbb240d89fc..20505b673ec 100644 --- a/dlls/kernel32/heap.c +++ b/dlls/kernel32/heap.c @@ -147,8 +147,6 @@ BOOL WINAPI HeapDestroy( HANDLE heap /* [in] Handle of heap */ ) * Global/local heap functions, keep in sync with kernelbase/memory.c ***********************************************************************/ -#include "pshpack1.h" - struct mem_entry { union @@ -156,15 +154,15 @@ struct mem_entry struct { WORD magic; - void *ptr; BYTE flags; BYTE lock; }; void *next_free; }; + void *ptr; }; -#include "poppack.h" +C_ASSERT(sizeof(struct mem_entry) == 2 * sizeof(void *)); struct kernelbase_global_data *kernelbase_global_data; @@ -181,7 +179,7 @@ static inline struct mem_entry *unsafe_mem_from_HLOCAL( HLOCAL handle ) { struct mem_entry *mem = CONTAINING_RECORD( handle, struct mem_entry, ptr ); struct kernelbase_global_data *data = kernelbase_global_data; - if (!((ULONG_PTR)handle & 2)) return NULL; + if (((UINT_PTR)handle & ((sizeof(void *) << 1) - 1)) != sizeof(void *)) return NULL; if (mem < data->mem_entries || mem >= data->mem_entries_end) return NULL; if (mem->magic != MAGIC_LOCAL_USED) return NULL; return mem; @@ -189,7 +187,7 @@ static inline struct mem_entry *unsafe_mem_from_HLOCAL( HLOCAL handle ) static inline void *unsafe_ptr_from_HLOCAL( HLOCAL handle ) { - if ((ULONG_PTR)handle & 2) return NULL; + if (((UINT_PTR)handle & ((sizeof(void *) << 1) - 1))) return NULL; return handle; } diff --git a/dlls/kernel32/tests/heap.c b/dlls/kernel32/tests/heap.c index 476be96cea8..5d6383a49e5 100644 --- a/dlls/kernel32/tests/heap.c +++ b/dlls/kernel32/tests/heap.c @@ -368,9 +368,7 @@ static void test_GlobalAlloc(void) mem = GlobalAlloc( GMEM_MOVEABLE, alloc_size ); ok( !!mem, "GlobalAlloc failed, error %lu\n", GetLastError() ); - todo_wine ok( ((UINT_PTR)mem & sizeof(void *)), "got unexpected entry align\n" ); - todo_wine ok( !((UINT_PTR)mem & (sizeof(void *) - 1)), "got unexpected entry align\n" ); entry = mem_entry_from_HANDLE( mem ); @@ -414,9 +412,7 @@ static void test_GlobalAlloc(void) ok( !tmp_mem, "GlobalFree failed, error %lu\n", GetLastError() ); ok( !!entry->flags, "got unexpected flags %#Ix\n", entry->flags ); ok( !((UINT_PTR)entry->flags & sizeof(void *)), "got unexpected ptr align\n" ); - todo_wine_if(sizeof(void *) == 4) ok( !((UINT_PTR)entry->flags & (sizeof(void *) - 1)), "got unexpected ptr align\n" ); - todo_wine ok( !entry->ptr, "got unexpected ptr %p\n", entry->ptr ); mem = GlobalAlloc( GMEM_MOVEABLE | GMEM_DISCARDABLE, 0 ); @@ -543,29 +539,24 @@ static void test_GlobalAlloc(void) ok( GetLastError() == ERROR_INVALID_HANDLE, "got error %lu\n", GetLastError() ); SetLastError( 0xdeadbeef ); flags = GlobalFlags( invalid_mem ); - todo_wine ok( flags == GMEM_INVALID_HANDLE, "GlobalFlags succeeded\n" ); - todo_wine ok( GetLastError() == ERROR_INVALID_HANDLE, "got error %lu\n", GetLastError() ); SetLastError( 0xdeadbeef ); size = GlobalSize( invalid_mem ); ok( size == 0, "GlobalSize succeeded\n" ); - todo_wine ok( GetLastError() == ERROR_INVALID_HANDLE, "got error %lu\n", GetLastError() ); SetLastError( 0xdeadbeef ); ptr = GlobalLock( invalid_mem ); ok( !ptr, "GlobalLock succeeded\n" ); - todo_wine ok( GetLastError() == ERROR_INVALID_HANDLE, "got error %lu\n", GetLastError() ); SetLastError( 0xdeadbeef ); ret = GlobalUnlock( invalid_mem ); - ok( ret, "GlobalUnlock failed, error %lu\n", GetLastError() ); todo_wine + ok( ret, "GlobalUnlock failed, error %lu\n", GetLastError() ); ok( GetLastError() == ERROR_INVALID_HANDLE, "got error %lu\n", GetLastError() ); SetLastError( 0xdeadbeef ); tmp_mem = GlobalReAlloc( invalid_mem, 0, GMEM_MOVEABLE ); ok( !tmp_mem, "GlobalReAlloc succeeded\n" ); - todo_wine ok( GetLastError() == ERROR_INVALID_HANDLE, "got error %lu\n", GetLastError() ); /* invalid pointers are caught */ @@ -889,29 +880,23 @@ static void test_LocalAlloc(void) ok( GetLastError() == ERROR_INVALID_HANDLE, "got error %lu\n", GetLastError() ); SetLastError( 0xdeadbeef ); flags = LocalFlags( invalid_mem ); - todo_wine ok( flags == LMEM_INVALID_HANDLE, "LocalFlags succeeded\n" ); - todo_wine ok( GetLastError() == ERROR_INVALID_HANDLE, "got error %lu\n", GetLastError() ); SetLastError( 0xdeadbeef ); size = LocalSize( invalid_mem ); ok( size == 0, "LocalSize succeeded\n" ); - todo_wine ok( GetLastError() == ERROR_INVALID_HANDLE, "got error %lu\n", GetLastError() ); SetLastError( 0xdeadbeef ); ptr = LocalLock( invalid_mem ); ok( !ptr, "LocalLock succeeded\n" ); - todo_wine ok( GetLastError() == ERROR_INVALID_HANDLE, "got error %lu\n", GetLastError() ); SetLastError( 0xdeadbeef ); ret = LocalUnlock( invalid_mem ); ok( !ret, "LocalUnlock succeeded\n" ); - todo_wine ok( GetLastError() == ERROR_INVALID_HANDLE, "got error %lu\n", GetLastError() ); SetLastError( 0xdeadbeef ); tmp_mem = LocalReAlloc( invalid_mem, 0, LMEM_MOVEABLE ); ok( !tmp_mem, "LocalReAlloc succeeded\n" ); - todo_wine ok( GetLastError() == ERROR_INVALID_HANDLE, "got error %lu\n", GetLastError() ); /* invalid pointers are caught */ diff --git a/dlls/kernelbase/memory.c b/dlls/kernelbase/memory.c index 5bdab31589d..086674ab41c 100644 --- a/dlls/kernelbase/memory.c +++ b/dlls/kernelbase/memory.c @@ -585,8 +585,6 @@ struct kernelbase_global_data struct mem_entry *mem_entries_end; }; -#include "pshpack1.h" - struct mem_entry { union @@ -594,15 +592,15 @@ struct mem_entry struct { WORD magic; - void *ptr; BYTE flags; BYTE lock; }; void *next_free; }; + void *ptr; }; -#include "poppack.h" +C_ASSERT(sizeof(struct mem_entry) == 2 * sizeof(void *)); #define MAX_MEM_HANDLES 0x10000 static struct mem_entry mem_entries[MAX_MEM_HANDLES]; @@ -626,7 +624,7 @@ static inline struct mem_entry *unsafe_mem_from_HLOCAL( HLOCAL handle ) { struct mem_entry *mem = CONTAINING_RECORD( handle, struct mem_entry, ptr ); struct kernelbase_global_data *data = &kernelbase_global_data; - if (!((ULONG_PTR)handle & 2)) return NULL; + if (((UINT_PTR)handle & ((sizeof(void *) << 1) - 1)) != sizeof(void *)) return NULL; if (mem < data->mem_entries || mem >= data->mem_entries_end) return NULL; if (mem->magic != MAGIC_LOCAL_USED) return NULL; return mem; @@ -639,7 +637,7 @@ static inline HLOCAL HLOCAL_from_mem( struct mem_entry *mem ) static inline void *unsafe_ptr_from_HLOCAL( HLOCAL handle ) { - if ((ULONG_PTR)handle & 2) return NULL; + if (((UINT_PTR)handle & ((sizeof(void *) << 1) - 1))) return NULL; return handle; } -- 2.35.1
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/kernelbase/memory.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/dlls/kernelbase/memory.c b/dlls/kernelbase/memory.c index 086674ab41c..9ae1b6d50dd 100644 --- a/dlls/kernelbase/memory.c +++ b/dlls/kernelbase/memory.c @@ -774,6 +774,7 @@ HLOCAL WINAPI DECLSPEC_HOTPATCH LocalFree( HLOCAL handle ) */ LPVOID WINAPI DECLSPEC_HOTPATCH LocalLock( HLOCAL handle ) { + HANDLE heap = GetProcessHeap(); struct mem_entry *mem; void *ret = NULL; @@ -794,28 +795,20 @@ LPVOID WINAPI DECLSPEC_HOTPATCH LocalLock( HLOCAL handle ) return ret; } - RtlLockHeap( GetProcessHeap() ); - __TRY + RtlLockHeap( heap ); + if ((mem = unsafe_mem_from_HLOCAL( handle ))) { - if ((mem = unsafe_mem_from_HLOCAL( handle ))) - { - ret = mem->ptr; - if (!mem->ptr) SetLastError( ERROR_DISCARDED ); - else if (mem->lock < LMEM_LOCKCOUNT) mem->lock++; - } - else - { - WARN_(globalmem)( "invalid handle %p\n", handle ); - SetLastError( ERROR_INVALID_HANDLE ); - } + ret = mem->ptr; + if (!mem->ptr) SetLastError( ERROR_DISCARDED ); + else if (mem->lock < LMEM_LOCKCOUNT) mem->lock++; } - __EXCEPT_PAGE_FAULT + else { - WARN_(globalmem)( "(%p): Page fault occurred ! Caused by bug ?\n", handle ); + WARN_(globalmem)( "invalid handle %p\n", handle ); SetLastError( ERROR_INVALID_HANDLE ); } - __ENDTRY - RtlUnlockHeap( GetProcessHeap() ); + RtlUnlockHeap( heap ); + return ret; } -- 2.35.1
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/kernelbase/memory.c | 35 ++++++++++++++--------------------- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/dlls/kernelbase/memory.c b/dlls/kernelbase/memory.c index 9ae1b6d50dd..06dbc66b7b9 100644 --- a/dlls/kernelbase/memory.c +++ b/dlls/kernelbase/memory.c @@ -918,6 +918,7 @@ HLOCAL WINAPI DECLSPEC_HOTPATCH LocalReAlloc( HLOCAL handle, SIZE_T size, UINT f */ BOOL WINAPI DECLSPEC_HOTPATCH LocalUnlock( HLOCAL handle ) { + HANDLE heap = GetProcessHeap(); struct mem_entry *mem; BOOL ret = FALSE; @@ -929,36 +930,28 @@ BOOL WINAPI DECLSPEC_HOTPATCH LocalUnlock( HLOCAL handle ) return FALSE; } - RtlLockHeap( GetProcessHeap() ); - __TRY + RtlLockHeap( heap ); + if ((mem = unsafe_mem_from_HLOCAL( handle ))) { - if ((mem = unsafe_mem_from_HLOCAL( handle ))) + if (mem->lock) { - if (mem->lock) - { - mem->lock--; - ret = (mem->lock != 0); - if (!ret) SetLastError( NO_ERROR ); - } - else - { - WARN_(globalmem)( "%p not locked\n", handle ); - SetLastError( ERROR_NOT_LOCKED ); - } + mem->lock--; + ret = (mem->lock != 0); + if (!ret) SetLastError( NO_ERROR ); } else { - WARN_(globalmem)( "invalid handle %p\n", handle ); - SetLastError( ERROR_INVALID_HANDLE ); + WARN_(globalmem)( "%p not locked\n", handle ); + SetLastError( ERROR_NOT_LOCKED ); } } - __EXCEPT_PAGE_FAULT + else { - WARN_(globalmem)( "(%p): Page fault occurred ! Caused by bug ?\n", handle ); - SetLastError( ERROR_INVALID_PARAMETER ); + WARN_(globalmem)( "invalid handle %p\n", handle ); + SetLastError( ERROR_INVALID_HANDLE ); } - __ENDTRY - RtlUnlockHeap( GetProcessHeap() ); + RtlUnlockHeap( heap ); + return ret; } -- 2.35.1
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/kernel32/heap.c | 54 ++++++++++++++++++++------------------ dlls/kernel32/tests/heap.c | 8 ------ dlls/kernelbase/memory.c | 41 ++++++++++++++++++----------- 3 files changed, 53 insertions(+), 50 deletions(-) diff --git a/dlls/kernel32/heap.c b/dlls/kernel32/heap.c index 20505b673ec..df094c94257 100644 --- a/dlls/kernel32/heap.c +++ b/dlls/kernel32/heap.c @@ -147,14 +147,19 @@ BOOL WINAPI HeapDestroy( HANDLE heap /* [in] Handle of heap */ ) * Global/local heap functions, keep in sync with kernelbase/memory.c ***********************************************************************/ +#define MEM_FLAG_USED 1 +#define MEM_FLAG_MOVEABLE 2 +#define MEM_FLAG_DISCARDABLE 4 +#define MEM_FLAG_DISCARDED 8 +#define MEM_FLAG_DDESHARE 0x8000 + struct mem_entry { union { struct { - WORD magic; - BYTE flags; + WORD flags; BYTE lock; }; void *next_free; @@ -166,7 +171,6 @@ C_ASSERT(sizeof(struct mem_entry) == 2 * sizeof(void *)); struct kernelbase_global_data *kernelbase_global_data; -#define MAGIC_LOCAL_USED 0x5342 #define POINTER_TO_HANDLE( p ) (*(((const HGLOBAL *)( p )) - 2)) /* align the storage needed for the HLOCAL on an 8-byte boundary thus * LocalAlloc/LocalReAlloc'ing with LMEM_MOVEABLE of memory with @@ -181,7 +185,7 @@ static inline struct mem_entry *unsafe_mem_from_HLOCAL( HLOCAL handle ) struct kernelbase_global_data *data = kernelbase_global_data; if (((UINT_PTR)handle & ((sizeof(void *) << 1) - 1)) != sizeof(void *)) return NULL; if (mem < data->mem_entries || mem >= data->mem_entries_end) return NULL; - if (mem->magic != MAGIC_LOCAL_USED) return NULL; + if (!(mem->flags & MEM_FLAG_USED)) return NULL; return mem; } @@ -431,32 +435,29 @@ VOID WINAPI GlobalUnfix( HGLOBAL handle ) */ UINT WINAPI GlobalFlags( HGLOBAL handle ) { + HANDLE heap = GetProcessHeap(); struct mem_entry *mem; - DWORD retval; + UINT flags; - TRACE_(globalmem)( "handle %p\n", handle ); + if (unsafe_ptr_from_HLOCAL( handle )) return 0; - if (unsafe_ptr_from_HLOCAL( handle )) + RtlLockHeap( heap ); + if ((mem = unsafe_mem_from_HLOCAL( handle ))) { - retval = 0; + flags = mem->lock; + if (mem->flags & MEM_FLAG_DISCARDABLE) flags |= GMEM_DISCARDABLE; + if (mem->flags & MEM_FLAG_DISCARDED) flags |= GMEM_DISCARDED; + if (mem->flags & MEM_FLAG_DDESHARE) flags |= GMEM_DDESHARE; } else { - RtlLockHeap( GetProcessHeap() ); - if ((mem = unsafe_mem_from_HLOCAL( handle ))) - { - retval = mem->lock + (mem->flags << 8); - if (mem->ptr == 0) retval |= GMEM_DISCARDED; - } - else - { - WARN_(globalmem)( "invalid handle %p\n", handle ); - SetLastError( ERROR_INVALID_HANDLE ); - retval = GMEM_INVALID_HANDLE; - } - RtlUnlockHeap( GetProcessHeap() ); + WARN_(globalmem)( "invalid handle %p\n", handle ); + SetLastError( ERROR_INVALID_HANDLE ); + flags = GMEM_INVALID_HANDLE; } - return retval; + RtlUnlockHeap( heap ); + + return flags; } @@ -491,10 +492,11 @@ SIZE_T WINAPI LocalCompact( UINT minfree ) * Windows memory management does not provide a separate local heap * and global heap. */ -UINT WINAPI LocalFlags( - HLOCAL handle /* [in] Handle of memory object */ -) { - return GlobalFlags( handle ); +UINT WINAPI LocalFlags( HLOCAL handle ) +{ + UINT flags = GlobalFlags( handle ); + if (flags & GMEM_DISCARDABLE) flags |= LMEM_DISCARDABLE; + return flags; } diff --git a/dlls/kernel32/tests/heap.c b/dlls/kernel32/tests/heap.c index 5d6383a49e5..566e2d6b987 100644 --- a/dlls/kernel32/tests/heap.c +++ b/dlls/kernel32/tests/heap.c @@ -334,7 +334,6 @@ static void test_GlobalAlloc(void) ok( size == 0, "GlobalSize returned %Iu\n", size ); ret = HeapValidate( GetProcessHeap(), 0, entry ); ok( !ret, "HeapValidate succeeded\n" ); - todo_wine ok( entry->flags == 0xf, "got unexpected flags %#Ix\n", entry->flags ); ok( !entry->ptr, "got unexpected ptr %p\n", entry->ptr ); mem = GlobalFree( mem ); @@ -347,7 +346,6 @@ static void test_GlobalAlloc(void) ok( size == 0, "GlobalSize returned %Iu\n", size ); ret = HeapValidate( GetProcessHeap(), 0, entry ); ok( !ret, "HeapValidate succeeded\n" ); - todo_wine ok( entry->flags == 0xb, "got unexpected flags %#Ix\n", entry->flags ); ok( !entry->ptr, "got unexpected ptr %p\n", entry->ptr ); mem = GlobalFree( mem ); @@ -389,14 +387,12 @@ static void test_GlobalAlloc(void) ok( !((UINT_PTR)ptr & (sizeof(void *) - 1)), "got unexpected ptr align\n" ); for (i = 1; i < 0xff; ++i) { - todo_wine ok( entry->flags == ((i<<16)|3), "got unexpected flags %#Ix\n", entry->flags ); ptr = GlobalLock( mem ); ok( !!ptr, "GlobalLock failed, error %lu\n", GetLastError() ); } ptr = GlobalLock( mem ); ok( !!ptr, "GlobalLock failed, error %lu\n", GetLastError() ); - todo_wine ok( entry->flags == 0xff0003, "got unexpected flags %#Ix\n", entry->flags ); for (i = 1; i < 0xff; ++i) { @@ -405,7 +401,6 @@ static void test_GlobalAlloc(void) } ret = GlobalUnlock( mem ); ok( !ret, "GlobalUnlock succeeded, error %lu\n", GetLastError() ); - todo_wine ok( entry->flags == 0x3, "got unexpected flags %#Ix\n", entry->flags ); tmp_mem = GlobalFree( mem ); @@ -418,7 +413,6 @@ static void test_GlobalAlloc(void) mem = GlobalAlloc( GMEM_MOVEABLE | GMEM_DISCARDABLE, 0 ); ok( !!mem, "GlobalAlloc failed, error %lu\n", GetLastError() ); entry = mem_entry_from_HANDLE( mem ); - todo_wine ok( entry->flags == 0xf, "got unexpected flags %#Ix\n", entry->flags ); ok( !entry->ptr, "got unexpected ptr %p\n", entry->ptr ); flags = GlobalFlags( mem ); @@ -429,7 +423,6 @@ static void test_GlobalAlloc(void) mem = GlobalAlloc( GMEM_MOVEABLE | GMEM_DISCARDABLE, 1 ); ok( !!mem, "GlobalAlloc failed, error %lu\n", GetLastError() ); entry = mem_entry_from_HANDLE( mem ); - todo_wine ok( entry->flags == 0x7, "got unexpected flags %#Ix\n", entry->flags ); ok( !!entry->ptr, "got unexpected ptr %p\n", entry->ptr ); flags = GlobalFlags( mem ); @@ -440,7 +433,6 @@ static void test_GlobalAlloc(void) mem = GlobalAlloc( GMEM_MOVEABLE | GMEM_DISCARDABLE | GMEM_DDESHARE, 1 ); ok( !!mem, "GlobalAlloc failed, error %lu\n", GetLastError() ); entry = mem_entry_from_HANDLE( mem ); - todo_wine ok( entry->flags == 0x8007, "got unexpected flags %#Ix\n", entry->flags ); ok( !!entry->ptr, "got unexpected ptr %p\n", entry->ptr ); flags = GlobalFlags( mem ); diff --git a/dlls/kernelbase/memory.c b/dlls/kernelbase/memory.c index 06dbc66b7b9..21e7c5ef9d9 100644 --- a/dlls/kernelbase/memory.c +++ b/dlls/kernelbase/memory.c @@ -585,14 +585,19 @@ struct kernelbase_global_data struct mem_entry *mem_entries_end; }; +#define MEM_FLAG_USED 1 +#define MEM_FLAG_MOVEABLE 2 +#define MEM_FLAG_DISCARDABLE 4 +#define MEM_FLAG_DISCARDED 8 +#define MEM_FLAG_DDESHARE 0x8000 + struct mem_entry { union { struct { - WORD magic; - BYTE flags; + WORD flags; BYTE lock; }; void *next_free; @@ -612,7 +617,6 @@ static struct kernelbase_global_data kernelbase_global_data = .mem_entries_end = mem_entries + MAX_MEM_HANDLES, }; -#define MAGIC_LOCAL_USED 0x5342 /* align the storage needed for the HLOCAL on an 8-byte boundary thus * LocalAlloc/LocalReAlloc'ing with LMEM_MOVEABLE of memory with * size = 8*k, where k=1,2,3,... allocs exactly the given size. @@ -626,12 +630,13 @@ static inline struct mem_entry *unsafe_mem_from_HLOCAL( HLOCAL handle ) struct kernelbase_global_data *data = &kernelbase_global_data; if (((UINT_PTR)handle & ((sizeof(void *) << 1) - 1)) != sizeof(void *)) return NULL; if (mem < data->mem_entries || mem >= data->mem_entries_end) return NULL; - if (mem->magic != MAGIC_LOCAL_USED) return NULL; + if (!(mem->flags & MEM_FLAG_USED)) return NULL; return mem; } static inline HLOCAL HLOCAL_from_mem( struct mem_entry *mem ) { + if (!mem) return 0; return &mem->ptr; } @@ -657,13 +662,18 @@ void *WINAPI KernelBaseGetGlobalData(void) */ HGLOBAL WINAPI DECLSPEC_HOTPATCH GlobalAlloc( UINT flags, SIZE_T size ) { - /* mask out obsolete flags */ - flags &= ~(GMEM_NOCOMPACT | GMEM_NOT_BANKED | GMEM_NOTIFY); + struct mem_entry *mem; + HGLOBAL handle; /* LocalAlloc allows a 0-size fixed block, but GlobalAlloc doesn't */ if (!(flags & GMEM_MOVEABLE) && !size) size = 1; - return LocalAlloc( flags, size ); + handle = LocalAlloc( flags, size ); + + if ((mem = unsafe_mem_from_HLOCAL( handle )) && (flags & GMEM_DDESHARE)) + mem->flags |= MEM_FLAG_DDESHARE; + + return handle; } @@ -712,12 +722,13 @@ HLOCAL WINAPI DECLSPEC_HOTPATCH LocalAlloc( UINT flags, SIZE_T size ) if (!mem) goto failed; handle = HLOCAL_from_mem( mem ); - mem->magic = MAGIC_LOCAL_USED; - mem->flags = flags >> 8; + mem->flags = MEM_FLAG_USED | MEM_FLAG_MOVEABLE; + if (flags & LMEM_DISCARDABLE) mem->flags |= MEM_FLAG_DISCARDABLE; mem->lock = 0; mem->ptr = NULL; - if (size) + if (!size) mem->flags |= MEM_FLAG_DISCARDED; + else { if (!(ptr = HeapAlloc( heap, heap_flags, size + HLOCAL_STORAGE ))) goto failed; *(HLOCAL *)ptr = handle; @@ -798,9 +809,8 @@ LPVOID WINAPI DECLSPEC_HOTPATCH LocalLock( HLOCAL handle ) RtlLockHeap( heap ); if ((mem = unsafe_mem_from_HLOCAL( handle ))) { - ret = mem->ptr; - if (!mem->ptr) SetLastError( ERROR_DISCARDED ); - else if (mem->lock < LMEM_LOCKCOUNT) mem->lock++; + if (!(ret = mem->ptr)) SetLastError( ERROR_DISCARDED ); + else if (!++mem->lock) mem->lock--; } else { @@ -935,13 +945,12 @@ BOOL WINAPI DECLSPEC_HOTPATCH LocalUnlock( HLOCAL handle ) { if (mem->lock) { - mem->lock--; - ret = (mem->lock != 0); + ret = (--mem->lock != 0); if (!ret) SetLastError( NO_ERROR ); } else { - WARN_(globalmem)( "%p not locked\n", handle ); + WARN_(globalmem)( "handle %p not locked\n", handle ); SetLastError( ERROR_NOT_LOCKED ); } } -- 2.35.1
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=111838 Your paranoid android. === debian11 (32 bit Hindi:India report) === kernel32: heap.c:1508: Test failed: got ullAvailPhys 0x9f543000 heap.c:1510: Test failed: got ullAvailPageFile 0xce33c000
participants (2)
-
Marvin -
Rémi Bernon