[PATCH] shell32: Remove duplicated assignment (Coverity).

[Nikolay Sivov]

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
---
 dlls/shell32/brsfolder.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/dlls/shell32/brsfolder.c b/dlls/shell32/brsfolder.c
index d771d0b5fb..37363a1cec 100644
--- a/dlls/shell32/brsfolder.c
+++ b/dlls/shell32/brsfolder.c
@@ -647,7 +647,6 @@ static LRESULT BrsFolder_Treeview_Keydown(browse_info *info, LPNMTVKEYDOWN keydo
             TV_ITEMDATA *item_data;
 
             item.mask  = TVIF_PARAM;
-            item.mask  = TVIF_HANDLE|TVIF_PARAM;
             item.hItem = selected_item;
             SendMessageW(info->hwndTreeView, TVM_GETITEMW, 0, (LPARAM)&item);
             item_data = (TV_ITEMDATA *)item.lParam;
-- 
2.20.1

[Marcus Meissner]

On Sun, Jan 27, 2019 at 09:33:02AM +0300, Nikolay Sivov wrote:
> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
> ---
>  dlls/shell32/brsfolder.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/dlls/shell32/brsfolder.c b/dlls/shell32/brsfolder.c
> index d771d0b5fb..37363a1cec 100644
> --- a/dlls/shell32/brsfolder.c
> +++ b/dlls/shell32/brsfolder.c
> @@ -647,7 +647,6 @@ static LRESULT BrsFolder_Treeview_Keydown(browse_info *info, LPNMTVKEYDOWN keydo
>              TV_ITEMDATA *item_data;
>
> item.mask  = TVIF_PARAM;
> -            item.mask  = TVIF_HANDLE|TVIF_PARAM;

You are removing TVIF_HANDLE?

Ciao, Marcus

[Nikolay Sivov]

On 1/28/19 12:56 PM, Marcus Meissner wrote:
> On Sun, Jan 27, 2019 at 09:33:02AM +0300, Nikolay Sivov wrote:
> > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
> > ---
> >   dlls/shell32/brsfolder.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/dlls/shell32/brsfolder.c b/dlls/shell32/brsfolder.c
> > index d771d0b5fb..37363a1cec 100644
> > --- a/dlls/shell32/brsfolder.c
> > +++ b/dlls/shell32/brsfolder.c
> > @@ -647,7 +647,6 @@ static LRESULT BrsFolder_Treeview_Keydown(browse_info *info, LPNMTVKEYDOWN keydo
> >               TV_ITEMDATA *item_data;
> >
> > item.mask  = TVIF_PARAM;
> > -            item.mask  = TVIF_HANDLE|TVIF_PARAM;
> > You are removing TVIF_HANDLE?

Yes, TVM_GETITEM works on item specified in hItem, and mask indicates 
data fields to return.TVIF_HANDLE does not do anything in this context.
> Ciao, Marcus