Re: winex11.drv: don't drop raw input events after mouse warp

[Patrick Rudolph]

Am 2014-12-17 20:56, schrieb Alexandre Julliard:
> Patrick Rudolph <siro(a)das-labor.org> writes:
> > This patch fixes bug https://bugs.winehq.org/show_bug.cgi?id=32913
> > After each mouse move the cursor is warped back to the center of the
> > screen. This is OK for XInput, but not for XInput2 as XInput2 reports
> > raw events that doesn't care about absolute screen coordinates and
> > doesn't need to be dropped. There're frequent cursor warps resulting
> > in lot's of dropped raw motion events (up to all). These dropped
> > motion events cause mouse jitter, which is notable in FPS games, but
> > not while using any GUI that only needs pixel coordinates.
>
> The problem is that warping the mouse also generates events, and you
> have to ignore those.

I've attached a log file, here: 
https://bugs.winehq.org/attachment.cgi?id=50258
As you can see XWarpCursor inserts MotionNotify events, that are 
correctly ignored using the serial, but there're no inserted RawMotion 
events. So there's no need to drop them, correct me if I'm wrong. Sadly 
I couldn't find any documentation for XWarpCursor and RawMotion events.

Kind Regards,
Patrick

winex11.drv: don't drop raw input events after mouse warp

[Alexandre Julliard]

Patrick Rudolph <siro(a)das-labor.org> writes:
> I've attached a log file, here:
> https://bugs.winehq.org/attachment.cgi?id=50258
> As you can see XWarpCursor inserts MotionNotify events, that are
> correctly ignored using the serial, but there're no inserted RawMotion
> events. So there's no need to drop them, correct me if I'm
> wrong. Sadly I couldn't find any documentation for XWarpCursor and
> RawMotion events.

That's the way it's supposed to behave, but sadly that's not true on all
systems, that's why I had to add that hack.

-- 
Alexandre Julliard
julliard(a)winehq.org