Re: [PATCH 2/2] opengl32: Check for valid context in wglGetProcAddress
On Sunday, June 24, 2012 10:42:11 PM Roderick Colenbrander wrote:
@@ -797,7 +797,7 @@ static void test_getprocaddress(HDC hdc) /* Temporarily disable the context, so we can see that we can't retrieve functions now. */ wglMakeCurrent(hdc, NULL); func = wglGetProcAddress("glActiveTextureARB"); - todo_wine ok(func == NULL, "Function lookup without a context passed, expected a failure; last error %#x\n", GetLastError()); + ok(func == NULL, "Function lookup without a context passed, expected a failure; last error %#x\n", GetLastError()); wglMakeCurrent(hdc, ctx); }
Does this apply to all functions, or just the ones MS's DLL doesn't implement? I could imagine wlgGetProcAddress still returning functions that are in opengl32.dll without worrying about the driver.
On Mon, Jun 25, 2012 at 1:22 AM, Chris Robinson <chris.kcat(a)gmail.com> wrote:
On Sunday, June 24, 2012 10:42:11 PM Roderick Colenbrander wrote:
@@ -797,7 +797,7 @@ static void test_getprocaddress(HDC hdc) /* Temporarily disable the context, so we can see that we can't retrieve functions now. */ wglMakeCurrent(hdc, NULL); func = wglGetProcAddress("glActiveTextureARB"); - todo_wine ok(func == NULL, "Function lookup without a context passed, expected a failure; last error %#x\n", GetLastError()); + ok(func == NULL, "Function lookup without a context passed, expected a failure; last error %#x\n", GetLastError()); wglMakeCurrent(hdc, ctx); }
Does this apply to all functions, or just the ones MS's DLL doesn't implement? I could imagine wlgGetProcAddress still returning functions that are in opengl32.dll without worrying about the driver.
From what I remember wglGetProcAddress doesn't return <GL1.1 functions which are in opengl32.dll. I can easily add a test for this.
Roderick
participants (2)
-
Chris Robinson -
Roderick Colenbrander