Re: Re: [2/2] ddraw: add dsurface dimension tests, try 11
Hi Henri, thanks for reviewing.
+ /* 6: Test maximum surface height */ + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, DDSCAPS_OFFSCREENPLAIN, 1, 0x10000, DDERR_INVALIDPARAMS}, + /* 7: Test maximum surface width */ + {DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT, DDSCAPS_OFFSCREENPLAIN, 0x10000, 1, DDERR_INVALIDPARAMS}, It would perhaps also be useful to verify that e.g. a 1 by 0xffff surface actually is allowed.
I've not included the tests for DirectDraw surfaces with dimension 1 by 0xffff and 0xffff by 1 as they fail on wine. The surfaces are provided by Opengl textures and the maximum texture size is less than 0xffff. However on Windows these tests pass, if the graphic cards pitch is great enough. Stefan pointed out that on old cards this test might fail. Should I add a separate test for this including a wine_todo ? I guess this won't be fixed any time soon... Regards, Patrick
On 15 July 2014 10:20, Patrick Rudolph <siro(a)das-labor.org> wrote:
I've not included the tests for DirectDraw surfaces with dimension 1 by 0xffff and 0xffff by 1 as they fail on wine. The surfaces are provided by Opengl textures and the maximum texture size is less than 0xffff. However on Windows these tests pass, if the graphic cards pitch is great enough. Stefan pointed out that on old cards this test might fail. Should I add a separate test for this including a wine_todo ? I guess this won't be fixed any time soon...
Marking it as todo_wine should be fine, although I wonder if you'll actually get a video memory surface that way, or only a system memory surface.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-07-15 10:20, schrieb Patrick Rudolph:
Stefan pointed out that on old cards this test might fail. If I remember correctly the problem was that some cards have a pitch limit of something slightly smaller than 2^17. So a width = 0xffff surface fails on some cards unless the format is a 8 bpp format. Testing a height = 0xffff surface should be fine though.
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTxTB3AAoJEN0/YqbEcdMwM44P/2qYCGmCojro8ce1YCriT6vk AEu6LzICoU65//UNQuTsravgHyGMWZldTmcNvoGzFPHN+qsk+17iPxCqzFVYQ7Gx IPtfFB49gpxJzo/n3n4EKSqusUrNIru3g/uR7FAHVgcRk2I5VUnU4eNDbat57HCl Z8/8yHAtqII1q/xMyWRFbCU6q10j0byKop5lT9tSQdSRwR13G+syku3OZ+1KIhld q3H6C7ovdGUoKykZRSni1H0TEQMmC2Eo2WKdL5wJHClHi53PIctb9clKj5MRA7vj Mw5zfrISyL8MOcpVqo1C3borWWEsLCyLpsBB2qgoEky6B7iDpMI4wR0YSBze9s5G cf4oQBIWa+o3HNEZDIEvdw3LVD0Mbhh9dRM5Z2CXOhi+r8c8DT6Xs1SFoQ/We1U0 kLt3QfVJBR8dP8N2JKPj6+Y6Wd0GGOmqeljFKX6USq8yhJfqyP0fZzvv1myFBIco w8umGm93n6TCXz/gTz3H+zqtbICb/UEsoqGkd+jFXqOdI3fSy5eejo7LUhmNifNl zRA+cNIAtlO4T6Ghirs9yNoP1fQP0rgDP6Qem+4fWXq1KR9WqD/98Sfa4Qn7TVB6 SC7pVxRYbMpfS75FPFSnCU48x+9mPqQjMZXCcUznAZLaS04/XGTaXT09u4HHnO+7 e6qQ1p1QRn+KShQ82nFq =YMbh -----END PGP SIGNATURE-----
participants (3)
-
Henri Verbeet -
Patrick Rudolph -
Stefan Dösinger