Re: mapi32: initialize session pointer to zero in MAPILogonEx (2nd resend)

[Austin English]

On Mon, Oct 6, 2008 at 12:26 PM, Louis. Lenders
<xerox_xerox2000(a)yahoo.co.uk> wrote:
> 2nd resend. If the patch is wrong, could you just tell me what's wrong with
> it? Might be handier, then me having to guess what's wrong...
>
> As the function is a complete stub, it's probably a good idea to initialize
> it to zero anyway.

diff --git a/dlls/mapi32/mapi32_main.c b/dlls/mapi32/mapi32_main.c
index 936d435..5aace9a 100644
--- a/dlls/mapi32/mapi32_main.c
+++ b/dlls/mapi32/mapi32_main.c
@@ -109,6 +109,7 @@ HRESULT WINAPI MAPILogonEx(ULONG_PTR uiparam,
LPWSTR profile,
 {
     FIXME("(0x%08lx %s %p 0x%08x %p) Stub\n", uiparam,
           debugstr_w(profile), password, flags, session);
+    *session=0;
     return SUCCESS_SUCCESS;
 }

The rest of the file uses ' = 0', so please stay consistent.

- Austin

mapi32: initialize session pointer to zero in MAPILogonEx (2nd resend)

[Juan Lang]

> diff --git a/dlls/mapi32/mapi32_main.c b/dlls/mapi32/mapi32_main.c
> index 936d435..5aace9a 100644
> --- a/dlls/mapi32/mapi32_main.c
> +++ b/dlls/mapi32/mapi32_main.c
> @@ -109,6 +109,7 @@ HRESULT WINAPI MAPILogonEx(ULONG_PTR uiparam,
> LPWSTR profile,
>  {
>     FIXME("(0x%08lx %s %p 0x%08x %p) Stub\n", uiparam,
>           debugstr_w(profile), password, flags, session);
> +    *session=0;
>     return SUCCESS_SUCCESS;
>  }
>
> The rest of the file uses ' = 0', so please stay consistent.

Also, the indenting is inconsistent:  the function uses 2-space
indenting, whereas your change uses 4-space indenting.  Please match
the file's existing style.
--Juan