Re: [AppDB] Resend: Fix typos and grammatical errors on test result pages

[KGJ]

Hi,

Alexander N. Sørnes wrote:
> Is there any reason why this patch was rejected?  I am not used to
> sending AppDB patches, so please let me know if there is something wrong
> with it.
>
> This patch fixes some typos reported by Rich, and a few grammatical
> errors I found while fixing it.
>
> Regards,
>
> Alexander N. Sørnes
>
> ------------------------------------------------------------------------
>
> Index: testResults.php
> ===================================================================
> RCS file: /home/wine/appdb/testResults.php,v
> retrieving revision 1.3
> diff -u -p -r1.3 testResults.php
> --- testResults.php	23 Jan 2006 02:10:31 -0000	1.3
> +++ testResults.php	30 Apr 2006 11:48:05 -0000
> @@ -1,6 +1,6 @@
>  <?php
>  /**************************************************/
> -/* code to submit, view and resubmit Test Results */
> +/* Code to submit, view and resubmit Test Results */
>  /**************************************************/
>
> include("path.php");
> @@ -111,10 +111,10 @@ if ($_REQUEST['sub'])
>
> //help
> -        echo "<p>This is the Screen for imputting testing information so that others looking at the database will know \n";
> -        echo "what was working or a particular release of Wine.</p>\n";
> +        echo "<p>This is the screen for inputting testing information so that others looking at the database will know \n";
> +        echo "what was working in a particular release of Wine.</p>\n";
>          echo "<p>Please be as detailed as you can.</p>\n";
> -        echo "<p>If you can not find your distribution on the list of existing Distributions please add it add it in the \n";
> +        echo "<p>If you can not find your distribution in the list of existing Distributions, please add it in the \n";
>          echo "field provided.</p>\n\n";
>
> if(!empty($errors))
> @@ -177,7 +177,7 @@ else // if ($_REQUEST['sub']) is not def
>      {
>          // help
>          echo "<div align=center><table width='90%' border=0 cellpadding=3 cellspacing=0><tr><td>\n\n";
> -        echo "<p>This is the list of Test Results waiting for submition, or to be deleted.</p>\n";
> +        echo "<p>This is the list of Test Results waiting for submission, or to be deleted.</p>\n";
>          echo "<p>To view a submission, click on its name. From that page you can delete or edit and\n";
>          echo "re-submit it into the AppDB .<br>\n";
>          echo "</td></tr></table></div>\n\n";
> @@ -200,7 +200,7 @@ else // if ($_REQUEST['sub']) is not def
>          echo "<div align=center><table width='90%' border=0 cellpadding=3 cellspacing=0><tr><td>\n\n";
>          echo "<p>This is the list of Rejected Test Results waiting for re-submition or deletion.</p>\n";

Shouldn't this line be also:

echo "<p>This is the list of Rejected Test Results waiting for re-submission or deletion.</p>\n";

or

echo "<p>This is the list of rejected Test Results waiting for re-submission or deletion.</p>\n";

? OK, that's not wrong with your patch but with the original file. I
just noticed it while reading...
> echo "<p>To view a submission, click on its name. From that page you can delete or edit and re-submit it into \n";
> -        echo "the AppDB .<br>\n";
> +        echo "the AppDB.<br>\n";
>          echo "</td></tr></table></div>\n\n";
>
> $oTest->ShowListofTests($hResult,"Rejected Testing Results");

Greetings KGJ