OSS Bug

[Rod Taylor]

http://bugs.winehq.com/long_list.cgi?buglist=1349

I think bug 1349 is related to the below conversation.

http://www.winehq.com/hypermail/wine-devel/2003/03/0379.html

Robert Reif suggested I send in a note.

-- 
Rod Taylor <rbt(a)rbt.ca>

PGP Key: http://www.rbt.ca/rbtpub.asc

[Robert Reif]

The problem Rod is seeing is caused by code that I added to
check the return value of an ioctl in OSS_RawOpenDevice.
The code now checks the return value and returns on failure
rather than ignoring it.  I don't know if this is a BSD issue or
a hardware driver issue or something else.

Rod Taylor wrote:
> http://bugs.winehq.com/long_list.cgi?buglist=1349
>
> I think bug 1349 is related to the below conversation.
>
> http://www.winehq.com/hypermail/wine-devel/2003/03/0379.html
>
> Robert Reif suggested I send in a note.
>
> --
> Rod Taylor <rbt(a)rbt.ca>
>
> PGP Key: http://www.rbt.ca/rbtpub.asc
>
> ------------------------------------------------------------------------
>                        Name: signature.asc
>    signature.asc       Type: application/x-unknown-content-type-asc_auto_file
>                 Description: This is a digitally signed message part

[Rod Taylor]

Found something related:

http://news.gw.com/freebsd.bugs/22626


According to it, FreeBSD doesn't have that ioctl as it's always on.

On Tue, 2003-04-01 at 19:09, Robert Reif wrote:
> The problem Rod is seeing is caused by code that I added to
> check the return value of an ioctl in OSS_RawOpenDevice.
> The code now checks the return value and returns on failure
> rather than ignoring it.  I don't know if this is a BSD issue or
> a hardware driver issue or something else.
>
> Rod Taylor wrote:
> > http://bugs.winehq.com/long_list.cgi?buglist=1349
> >
> > I think bug 1349 is related to the below conversation.
> >
> > http://www.winehq.com/hypermail/wine-devel/2003/03/0379.html
> >
> > Robert Reif suggested I send in a note.
> >
> > --
> > Rod Taylor <rbt(a)rbt.ca>
> >
> > PGP Key: http://www.rbt.ca/rbtpub.asc
> >
> > ------------------------------------------------------------------------
> >                        Name: signature.asc
> >    signature.asc       Type: application/x-unknown-content-type-asc_auto_file
> >                 Description: This is a digitally signed message part

-- 
Rod Taylor <rbt(a)rbt.ca>

PGP Key: http://www.rbt.ca/rbtpub.asc

[Eric Pouech]

Rod Taylor wrote:
> Found something related:
>
> http://news.gw.com/freebsd.bugs/22626
>
> According to it, FreeBSD doesn't have that ioctl as it's always on.

what errno value do you get when the call fails ?
I'd suggest we ignore the error if ioctl returns -1 with this specific 
errno (if possible)

A+
-- 
Eric Pouech

[Rod Taylor]

By default it seems to return EINVAL.

Line 953
http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/sound/pcm/dsp.c?annotate=1...

On Wed, 2003-04-02 at 13:20, Eric Pouech wrote:
> Rod Taylor wrote:
> > Found something related:
> >
> > http://news.gw.com/freebsd.bugs/22626
> >
> > According to it, FreeBSD doesn't have that ioctl as it's always on.
>
> what errno value do you get when the call fails ?
> I'd suggest we ignore the error if ioctl returns -1 with this specific 
> errno (if possible)
>
> A+
> -- 
> Rod Taylor <rbt(a)rbt.ca>

PGP Key: http://www.rbt.ca/rbtpub.asc

[Eric Pouech]

Rod Taylor wrote:
> By default it seems to return EINVAL.
>
> Line 953
> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/sound/pcm/dsp.c?annotate=1...
> so something like this should do.

A+

-- 
Eric Pouech

Index: dlls/winmm/wineoss/audio.c
===================================================================
RCS file: /home/cvs/cvsroot/wine/wine/dlls/winmm/wineoss/audio.c,v
retrieving revision 1.81
diff -u -r1.81 audio.c
--- dlls/winmm/wineoss/audio.c	17 Mar 2003 00:00:53 -0000	1.81
+++ dlls/winmm/wineoss/audio.c	3 Apr 2003 19:47:39 -0000
@@ -278,7 +278,11 @@
     /* turn full duplex on if it has been requested */
     if (ossdev->open_access == O_RDWR && ossdev->full_duplex) {
         rc = ioctl(fd, SNDCTL_DSP_SETDUPLEX, 0);
-        if (rc != 0) {
+        /* on *BSD, as full duplex is always enabled by default, this ioctl
+         * will fail with EINVAL
+         * so, we don't consider EINVAL an error here
+         */
+        if (rc != 0 && errno != EINVAL) {
 	    ERR("ioctl(%s, SNDCTL_DSP_SETDUPLEX) failed (%s)\n", ossdev->dev_name, strerror(errno));
             goto error;
 	}

[Rod Taylor]

Sound works again with this patch.

On Thu, 2003-04-03 at 14:48, Eric Pouech wrote:
> Rod Taylor wrote:
> > By default it seems to return EINVAL.
> >
> > Line 953
> > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/sound/pcm/dsp.c?annotate=1...
> > so something like this should do.
>
> A+
> -- 
> Rod Taylor <rbt(a)rbt.ca>

PGP Key: http://www.rbt.ca/rbtpub.asc