Re: [PATCH 6/9] wined3d: Generate code for compute shaders.

[Matteo Bruni]

2017-02-09 12:00 GMT+01:00 Józef Kucia <jkucia(a)codeweavers.com>:
> +    shader_id = GL_EXTCALL(glCreateShader(GL_COMPUTE_SHADER));
> +
> +    shader_addline(buffer, "%s\n", shader_glsl_get_version_declaration(gl_info, ®_maps->shader_version));
> +
> +    shader_glsl_enable_extensions(buffer, gl_info);
> +    if (gl_info->supported[ARB_COMPUTE_SHADER])
> +        shader_addline(buffer, "#extension GL_ARB_compute_shader : enable\n");

I don't know it for a fact but it seems weird to me that explicitly
enabling the extension in the GLSL source is ever necessary, given
that you just created the shader with GL_COMPUTE_SHADER anyway... FWIW
the extension enable is not mentioned in the ARB_compute_shader spec.

[PATCH 6/9] wined3d: Generate code for compute shaders.

[Józef Kucia]

On Thu, Feb 9, 2017 at 3:39 PM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
> I don't know it for a fact but it seems weird to me that explicitly
> enabling the extension in the GLSL source is ever necessary, given
> that you just created the shader with GL_COMPUTE_SHADER anyway... FWIW
> the extension enable is not mentioned in the ARB_compute_shader spec.

In practice this seems to be necessary.

fixme:d3d_shader:print_glsl_info_log     0(18) : error C7532: global
variable gl_WorkGroupID requires "#version 430  " or later
fixme:d3d_shader:print_glsl_info_log     0(18) : error C0000: ... or
#extension GL_ARB_compute_shader : enable
fixme:d3d_shader:print_glsl_info_log     (0) : error C2003:
incompatible options for link

[PATCH 6/9] wined3d: Generate code for compute shaders.

[Matteo Bruni]

2017-02-09 15:52 GMT+01:00 Józef Kucia <joseph.kucia(a)gmail.com>:
> On Thu, Feb 9, 2017 at 3:39 PM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
> > I don't know it for a fact but it seems weird to me that explicitly
> > enabling the extension in the GLSL source is ever necessary, given
> > that you just created the shader with GL_COMPUTE_SHADER anyway... FWIW
> > the extension enable is not mentioned in the ARB_compute_shader spec.
>
> In practice this seems to be necessary.
>
> fixme:d3d_shader:print_glsl_info_log     0(18) : error C7532: global
> variable gl_WorkGroupID requires "#version 430  " or later
> fixme:d3d_shader:print_glsl_info_log     0(18) : error C0000: ... or
> #extension GL_ARB_compute_shader : enable
> fixme:d3d_shader:print_glsl_info_log     (0) : error C2003:
> incompatible options for link

Nevermind then :/