Re: Vijay Kiran Kamuju : comctl32: MonthCalendar - Fix highlighting of current date.

[Duane Clark]

Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: c5b8df481f2bb0362b57188a8c7df423030ba8b0
> URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c5b8df481f2bb0362b57188a8c...
>
> Author: Vijay Kiran Kamuju <infyquest(a)gmail.com>
> Date:   Sun Dec 24 13:31:56 2006 +0530
>
> comctl32: MonthCalendar - Fix highlighting of current date.

That does highlight the current date on startup. But I notice that when 
I click another date, the current date doesn't get unhighlighted.

Vijay Kiran Kamuju : comctl32: MonthCalendar - Fix highlighting of current date.

[Vijay Kiran Kamuju]

Hi,

It did it for me. when I did the tests.
I will check again.
Currently I am out of net access for atleast 2 weeks.
Shifting to a new room(hostel).
So I will test it soon, please bear with me, and also please test with
my other patch(month calander one). May be I should leave that for
Dan's students.
But I will fix it as this is my bug, anyways.

bye,
VJ

On 12/26/06, Duane Clark <dclark(a)akamail.com> wrote:
> Alexandre Julliard wrote:
> > Module: wine
> > Branch: master
> > Commit: c5b8df481f2bb0362b57188a8c7df423030ba8b0
> > URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c5b8df481f2bb0362b57188a8c...
> >
> > Author: Vijay Kiran Kamuju <infyquest(a)gmail.com>
> > Date:   Sun Dec 24 13:31:56 2006 +0530
> >
> > comctl32: MonthCalendar - Fix highlighting of current date.
>
> That does highlight the current date on startup. But I notice that when
> I click another date, the current date doesn't get unhighlighted.

Vijay Kiran Kamuju : comctl32: MonthCalendar - Fix highlighting of current date.

[Lei Zhang]

I see the problem Duane reports as well. As long as you stay with in
the current month, the current day will remain highlighted even if you
click another date. It will disappear if you (a) highlight the current
date, then another date, or (b) if you go to another month.

On 12/26/06, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote:
> Hi,
>
> It did it for me. when I did the tests.
> I will check again.
> Currently I am out of net access for atleast 2 weeks.
> Shifting to a new room(hostel).
> So I will test it soon, please bear with me, and also please test with
> my other patch(month calander one). May be I should leave that for
> Dan's students.
> But I will fix it as this is my bug, anyways.
>
> bye,
> VJ
>
> On 12/26/06, Duane Clark <dclark(a)akamail.com> wrote:
> > Alexandre Julliard wrote:
> > > Module: wine
> > > Branch: master
> > > Commit: c5b8df481f2bb0362b57188a8c7df423030ba8b0
> > > URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c5b8df481f2bb0362b57188a8c...
> > >
> > > Author: Vijay Kiran Kamuju <infyquest(a)gmail.com>
> > > Date:   Sun Dec 24 13:31:56 2006 +0530
> > >
> > > comctl32: MonthCalendar - Fix highlighting of current date.
> >
> > That does highlight the current date on startup. But I notice that when
> > I click another date, the current date doesn't get unhighlighted.

Vijay Kiran Kamuju : comctl32: MonthCalendar - Fix highlightingof current date.

[Dmitry Timoshkov]

"Lei Zhang" <thestig(a)google.com> wrote:
> I see the problem Duane reports as well. As long as you stay with in
> the current month, the current day will remain highlighted even if you
> click another date. It will disappear if you (a) highlight the current
> date, then another date, or (b) if you go to another month.
>
> On 12/26/06, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote:
> > Hi,
> >
> > It did it for me. when I did the tests.
> > I will check again.
> > Currently I am out of net access for atleast 2 weeks.
> > Shifting to a new room(hostel).
> > So I will test it soon, please bear with me, and also please test with
> > my other patch(month calander one). May be I should leave that for
> > Dan's students.
> > But I will fix it as this is my bug, anyways.

Since 2 independent persons do see that the patch has caused a regression,
and it's not going to be fixed in a reasonable amount of time, I'd suggest
to revert that patch as an obviously wrong then.

-- 
Dmitry.

Vijay Kiran Kamuju : comctl32: MonthCalendar - Fix highlightingof current date.

[Vijay Kiran Kamuju]

Hi,

It might be because of the MULTISELECT style not being set.
Can you please test with the MULTISELECT set?
In the older version of the control spy test its set by default, and
in the new version its not set.
Can you please test that and also test by applying the other patch as well?
Currently I am tidying it up and putting some comments.
As the order of messages sent is a bit messed up.
Dimitry:
What do we need to setup, if we want a test framework for messages in
comctl32 similar to  user32?
Lei and Dan,
This can also be a good exercise.
But I will try to do it myself first.

Cheers,
VJ

On 12/27/06, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote:
> "Lei Zhang" <thestig(a)google.com> wrote:
> > I see the problem Duane reports as well. As long as you stay with in
> > the current month, the current day will remain highlighted even if you
> > click another date. It will disappear if you (a) highlight the current
> > date, then another date, or (b) if you go to another month.
> >
> > On 12/26/06, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote:
> > > Hi,
> > >
> > > It did it for me. when I did the tests.
> > > I will check again.
> > > Currently I am out of net access for atleast 2 weeks.
> > > Shifting to a new room(hostel).
> > > So I will test it soon, please bear with me, and also please test with
> > > my other patch(month calander one). May be I should leave that for
> > > Dan's students.
> > > But I will fix it as this is my bug, anyways.
>
> Since 2 independent persons do see that the patch has caused a regression,
> and it's not going to be fixed in a reasonable amount of time, I'd suggest
> to revert that patch as an obviously wrong then.
>
> --
> Dmitry.

Vijay Kiran Kamuju : comctl32: MonthCalendar - Fixhighlightingof current date.

[Dmitry Timoshkov]

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote:
> What do we need to setup, if we want a test framework for messages in
> comctl32 similar to  user32?

Some kind of a message queue is needed and a mechanism to check what
has been gathered with an expected sequence. I'd suggest to not invent
a wheel and copy existing parts from dlls/user32/tests/msg.c.

-- 
Dmitry.

Vijay Kiran Kamuju : comctl32: MonthCalendar - Fix highlightingof current date.

[James Hawkins]

On 12/27/06, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote:
> Hi,
>
> It might be because of the MULTISELECT style not being set.
> Can you please test with the MULTISELECT set?
> In the older version of the control spy test its set by default, and
> in the new version its not set.
> Can you please test that and also test by applying the other patch as well?
> Currently I am tidying it up and putting some comments.
> As the order of messages sent is a bit messed up.
> Dimitry:
> What do we need to setup, if we want a test framework for messages in
> comctl32 similar to  user32?
> Lei and Dan,
> This can also be a good exercise.
> But I will try to do it myself first.
>
> Cheers,
> VJ

I wouldn't worry about it.  I have a patch that adds message testing
for comctl32.  I'll send it in when I get back from vacation (couple
of days, stuck in a blizzard).

-- 
James Hawkins