[PATCH v2] supersede 232632

[Eric Pouech]

dlls/kernel32/tests: correctly handle shell_no_window console in process.c

should fix testbot daily failures for kernel32:process

V1 -> V2: the FreeConsole() call under windows leads to children crashes in
test_parent_process_attribute(), so I took the simple path of only calling
FreeConsole() when testing under Wine

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com>

---
 dlls/kernel32/tests/process.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c
index 8f18a0d37a7..ef2f1e45843 100644
--- a/dlls/kernel32/tests/process.c
+++ b/dlls/kernel32/tests/process.c
@@ -1543,6 +1543,8 @@ static void test_Console(void)
     /* first, we need to be sure we're attached to a console */
     if (!is_console(startup.hStdInput) || !is_console(startup.hStdOutput))
     {
+        /* could be attached to a Wine shell_no_window console, so detach */
+        if (!strcmp(winetest_platform, "wine")) FreeConsole();
         /* we're not attached to a console, let's do it */
         AllocConsole();
         startup.hStdInput = CreateFileA("CONIN$", GENERIC_READ|GENERIC_WRITE, 0, &sa, OPEN_EXISTING, 0, 0);

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=112643

Your paranoid android.


=== debian11 (32 bit Hindi:India report) ===

kernel32:
process.c:1584: Test failed: GetLastError: expecting 87 got 6
process.c:1594: Test failed: GetLastError: expecting 87 got 6