Re: [PATCH] oleaut32: Implement DISPID_PICT_RENDER dispid

[Alistair Leslie-Hughes]

On 26/02/2014 8:05 PM, Nikolay Sivov wrote:
> ---
>   dlls/oleaut32/olepicture.c | 51 ++++++++++++++++++++++++++++++++++++++++++----
>   1 file changed, 47 insertions(+), 4 deletions(-)

I submitted a similar patch
http://www.winehq.org/pipermail/wine-patches/2011-December/109566.html

It was rejected because it lacked tests.


Best Regards
Alistair Leslie-Hughes

[PATCH] oleaut32: Implement DISPID_PICT_RENDER dispid

[Nikolay Sivov]

On 2/26/2014 13:19, Alistair Leslie-Hughes wrote:
> On 26/02/2014 8:05 PM, Nikolay Sivov wrote:
> > ---
> >   dlls/oleaut32/olepicture.c | 51 
> > ++++++++++++++++++++++++++++++++++++++++++----
> >   1 file changed, 47 insertions(+), 4 deletions(-)
>
> I submitted a similar patch
> http://www.winehq.org/pipermail/wine-patches/2011-December/109566.html
>
> It was rejected because it lacked tests.
> Without wine-devel comment? Cause I can't find any.
> +      VariantInit(&varRect);
> +      hr = VariantChangeTypeEx(&varRect, &pDispParams->rgvarg[0], lcid, 0, VT_UI4 | VT_BYREF);
> +      if (hr == S_OK)
> +        pRect = V_INT_PTR(&varRect);
> This part is wrong.