RE: Fixing include quotes (was: Re: conformance test for ShellExecute)
On December 30, 2002 03:41 pm, Patrik Stridvall wrote:
I'm already on it by improving winapi_cleanup.
Very well, I've put you up for it instead. But make sure you don't over do it :)
Well, for the future I have planned grouping and automatic addition of #ifdef HAVE_ and that sort of things. That is overdoing a little perhaps but it will look nicer. :-)
It seems to me the algo is simple (if the include can not be accessed relative to the dir in which the .c file is, change it to <>),
This is that it already does I think. Please try it out yourself.
and the operation is really one time.
It depends what you mean by one time. People make mistakes. winapi_cleanup does C++ comment to C comment conversion and this is "one time" as well...
So if you have something that works, let's just get the patch (and here I'm referring to the one that does the actual "" to <> change) in, and check this off.
I think it is better than Alexandre runs winapi_cleanup --include-quotes himself if he thinks it does the correct things. If not please inform me what the problem is. In my tree, the patch is over 800k.
On December 31, 2002 06:41 am, Patrik Stridvall wrote:
I think it is better than Alexandre runs winapi_cleanup --include-quotes himself if he thinks it does the correct things.
Well, that's cool, but your original message gave the impression that this is still a work in progress not ready to be used. Which it seems is the wrong impression. Just let Alexandre know to run the above mentioned command after applying your patch, that will do. BTW, did you compile Wine after this patch? If it compiles, then I don't think there is any problem, no? In fact, if it compiles we are *guaranteed* that the result is correct because we don't have any duplicated header filename: [dimi(a)dimi wine.src]$ find -name "*.h" | sed 's%.*/%%' | sort -u | uniq -c | sort -rn | head -1 1 zmouse.h -- Dimi.
On Tue, Dec 31, 2002 at 01:30:10PM -0500, Dimitrie O. Paun wrote:
[dimi(a)dimi wine.src]$ find -name "*.h" | sed 's%.*/%%' | sort -u | uniq -c | sort -rn | head -1
Isn't the result of sort -u | uniq -c always either 1 or nothing at all? ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.
On January 1, 2003 12:39 am, Joerg Mayer wrote:
Isn't the result of sort -u | uniq -c always either 1 or nothing at all?
But of course, silly me: [dimi(a)dimi wine.src]$ find -name "*.h" | sed 's%.*/%%' | sort | uniq -c | sort -rn | head -15 11 main.h 4 user.h 4 resource.h 3 utils.h 3 license.h 3 hal.h 2 unicode.h 2 thread.h 2 shlobj.h 2 regproc.h 2 process.h 2 parser.h 2 dialog.h 2 async.h 1 zmouse.h Anyway, only a few headers are duplicated, so they should be simple to check. -- Dimi.
"Patrik Stridvall" <ps(a)leissner.se> writes:
I think it is better than Alexandre runs winapi_cleanup --include-quotes himself if he thinks it does the correct things. If not please inform me what the problem is.
In my tree, the patch is over 800k.
I'm not sure there's much point in fixing all the C files. It works fine the way it is now, the only thing that we need the change is the exported headers. -- Alexandre Julliard julliard(a)winehq.com
participants (4)
-
Alexandre Julliard -
Dimitrie O. Paun -
Joerg Mayer -
Patrik Stridvall