[PATCH 1/8] winedump: Correctly declare the array of segments.

[Dmitry Timoshkov]

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru>
---
 tools/winedump/tlb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/winedump/tlb.c b/tools/winedump/tlb.c
index df1ea4b576..5c710360e6 100644
--- a/tools/winedump/tlb.c
+++ b/tools/winedump/tlb.c
@@ -109,7 +109,7 @@ typedef struct seg_t {
     int offset;
     int length;
 } seg_t;
-static seg_t segdir[];
+static seg_t segdir[15];
 
 enum SEGDIRTYPE {
     SEGDIR_TYPEINFO,
-- 
2.17.1

[Jacek Caban]

On 07/10/2018 05:41 AM, Dmitry Timoshkov wrote:
> Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru>
> ---
>  tools/winedump/tlb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/winedump/tlb.c b/tools/winedump/tlb.c
> index df1ea4b576..5c710360e6 100644
> --- a/tools/winedump/tlb.c
> +++ b/tools/winedump/tlb.c
> @@ -109,7 +109,7 @@ typedef struct seg_t {
>      int offset;
>      int length;
>  } seg_t;
> -static seg_t segdir[];
> +static seg_t segdir[15];

I'm not opposed to the patch, but is it really needed? It's just a
forward declaration, we declare it with an initializer of known length
later in the file.

Jacek

[Dmitry Timoshkov]

Jacek Caban <jacek(a)codeweavers.com> wrote:
> > -static seg_t segdir[];
> > +static seg_t segdir[15];
>
> I'm not opposed to the patch, but is it really needed? It's just a
> forward declaration, we declare it with an initializer of known length
> later in the file.

Compilation with MSVC/PSDK compiler fails because of this.

-- 
Dmitry.

[Jacek Caban]

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>