Re: [PATCH] wined3d: Pass correct coord parameter to texture*DProj functions

[H. Verbeet]

On 04/08/07, Vitaly Budovski <vbudovski(a)gmail.com> wrote:
> ---
>   dlls/wined3d/glsl_shader.c |    9 +++++++++
>   1 files changed, 9 insertions(+), 0 deletions(-)

This patch is plain wrong. The caller of
shader_glsl_get_sample_function() is responsible for correctly adding
the correct component for projected lookups, since that isn't always
the "next" component, but in fact depends on the instruction that does
the sampling.

Of course if the author of this patch had actually read the source for
the callers of shader_glsl_get_sample_function() (pshader_glsl_tex()
in particular...) or alternatively had been familiar with D3D shader
assembly, he would have known that.

It does make me wonder though, particularly given the lack of any
explanation for the patch, if this is actually supposed to fix
anything?