Re: [PATCH 4/7] d3drm: Implement IDirect3DRM*_CreateTexture. (v6)

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2016-05-13 um 22:21 schrieb Aaryaman Vasishta:
> -    *texture = &object->IDirect3DRMTexture3_iface;
> +    if (FAILED(IDirect3DRMTexture3_InitFromImage(*texture, image)))
> +    {
> +        IDirect3DRMTexture3_Release(*texture);
> +        return D3DRMERR_BADVALUE;
> +    }
> This will leave a non-NULL pointer stored in *texture, which is most likely wrong. Please extend your tests to check for this.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXOgmWAAoJEN0/YqbEcdMw4PQP/1Ri28V/xXTb90aSLvHLi3QQ
47cGk1M2C9/z3bj9kZUKfYGADCJVgdf52bcFQUb4yBBEkxtY2RrAYMAY2218l0PB
QcNpkFhVEnauRII4CsoLShByEtKLfLo6sqflABUKoBfK9BELjz4QpDEUiMvyKHXk
vRtesZBK16VaFnwbpQekFb233/sID9oCLitNzIXJ6ntNLEvGYCgfWmaT9VdXNGvv
zvnQfWh8ayXbJGulUclNectDqA2ww+vRxHmC5dkgAVGHsfxOp1dY3Z45b6CNPksE
iyxn6A3mAVgy6hhjbm8AjgN/8agkvwDRhL2774ZdemBCL1FAq39kFobSNju4evAx
YH6r8bFiN1y3814hxMe74Zk2oXJsCN4ZL5ZxOOabJHdWHCxTDWU8yikordtlfdF2
q1Va/GVi9aKLXiWhfNjusP5bG/DY8hK14dRe570eWP2U9fKbDaFLc8iVhwxZRs0N
3EJddB286uvLjAGEbGEe5iSPTuTKCER0L/8rRTliczYt5rJeX+2955bTZu3ek5Uu
XjmOzBP5374IiBDai1dhHX2EwTD3UxisN2olDUfFGee8DkDjzowKt5hFBYVT7x8j
hDU7rkRKht2loO7vKEqX+uM9twplIWVIIcQWY2ZXT7gZ8x07bCqVa8eHhKy63cGp
J1YMc8wPUUENq+iVYZ1W
=sm0l
-----END PGP SIGNATURE-----

[PATCH 4/7] d3drm: Implement IDirect3DRM*_CreateTexture. (v6)

[Aaryaman Vasishta]

It actually sets them to NULL. I'll resend the patch including tests to
account for this. I believe even LoadTexture would need similar tests as
well.

Cheers,
Aaryaman

On Mon, May 16, 2016 at 11:25 PM, Stefan Dösinger <stefandoesinger(a)gmail.com
> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Am 2016-05-13 um 22:21 schrieb Aaryaman Vasishta:
> > -    *texture = &object->IDirect3DRMTexture3_iface;
> > +    if (FAILED(IDirect3DRMTexture3_InitFromImage(*texture, image)))
> > +    {
> > +        IDirect3DRMTexture3_Release(*texture);
> > +        return D3DRMERR_BADVALUE;
> > +    }
> > This will leave a non-NULL pointer stored in *texture, which is most
> > likely wrong. Please extend your tests to check for this.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBCAAGBQJXOgmWAAoJEN0/YqbEcdMw4PQP/1Ri28V/xXTb90aSLvHLi3QQ
> 47cGk1M2C9/z3bj9kZUKfYGADCJVgdf52bcFQUb4yBBEkxtY2RrAYMAY2218l0PB
> QcNpkFhVEnauRII4CsoLShByEtKLfLo6sqflABUKoBfK9BELjz4QpDEUiMvyKHXk
> vRtesZBK16VaFnwbpQekFb233/sID9oCLitNzIXJ6ntNLEvGYCgfWmaT9VdXNGvv
> zvnQfWh8ayXbJGulUclNectDqA2ww+vRxHmC5dkgAVGHsfxOp1dY3Z45b6CNPksE
> iyxn6A3mAVgy6hhjbm8AjgN/8agkvwDRhL2774ZdemBCL1FAq39kFobSNju4evAx
> YH6r8bFiN1y3814hxMe74Zk2oXJsCN4ZL5ZxOOabJHdWHCxTDWU8yikordtlfdF2
> q1Va/GVi9aKLXiWhfNjusP5bG/DY8hK14dRe570eWP2U9fKbDaFLc8iVhwxZRs0N
> 3EJddB286uvLjAGEbGEe5iSPTuTKCER0L/8rRTliczYt5rJeX+2955bTZu3ek5Uu
> XjmOzBP5374IiBDai1dhHX2EwTD3UxisN2olDUfFGee8DkDjzowKt5hFBYVT7x8j
> hDU7rkRKht2loO7vKEqX+uM9twplIWVIIcQWY2ZXT7gZ8x07bCqVa8eHhKy63cGp
> J1YMc8wPUUENq+iVYZ1W
> =sm0l
> -----END PGP SIGNATURE-----