[PATCH 1/1] rasapi32: Add stub for RasGetConnectionStatistics

[Станислав Мотыльков]

Hello!

I attached a patch for consideration.

Regards,
Stas'M.

[Alex Henrie]

Hello Stanislav, and thank you for your interest in Wine! Does this
patch fix a bug?

-Alex

[Станислав Мотыльков]

Hello Alex!

This patch allows to run some programs that require this API --
without it they can't start. Don't know whether there are existing
bug-reports in Wine referring this, but there's open bug report in
ReactOS project tracker:
https://jira.reactos.org/browse/CORE-10426

Also I sent a pull request to ReactOS repo with the same patch, but it
still pending due to requirement of upstream sync:
https://github.com/reactos/reactos/pull/12

Regards,
Stas'M.

On 11/22/17, Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> Hello Stanislav, and thank you for your interest in Wine! Does this
> patch fix a bug?
>
> -Alex

[Alex Henrie]

2017-11-22 6:33 GMT-07:00 Станислав Мотыльков <x86corez(a)gmail.com>:
> This patch allows to run some programs that require this API --
> without it they can't start. Don't know whether there are existing
> bug-reports in Wine referring this, but there's open bug report in
> ReactOS project tracker:
> https://jira.reactos.org/browse/CORE-10426

OK. There are still two more problems. First, the patch does not compile:

rasapi.c: In function ‘RasGetConnectionStatistics’:
rasapi.c:554:12: error: ‘ERROR_UNKNOWN’ undeclared (first use in this
function); did you mean ‘DRIVE_UNKNOWN’?
     return ERROR_UNKNOWN;
            ^~~~~~~~~~~~~
            DRIVE_UNKNOWN

It looks like you forgot to include the change to raserror.h that was
included in your Wine Staging patch:
https://github.com/wine-compholio/wine-staging/blob/master/patches/rasapi32-...

Second, you need to include a Signed-off-by line in your commit
message. See https://wiki.winehq.org/Submitting_Patches#The_commit_message

-Alex

[Станислав Мотыльков]

Indeed, that change in header file was done by Sebastian Lackner, he
accepted my patch in Wine Staging:
https://dev.wine-staging.com/patches/203/

Attached my updated patch.

Also can you advice whether this is ok to send patch that already was
submitted to Wine Staging, should I wait for it or it is normal to go
forward?

Regards,
Stas'M.

On 11/22/17, Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> 2017-11-22 6:33 GMT-07:00 Станислав Мотыльков <x86corez(a)gmail.com>:
> > This patch allows to run some programs that require this API --
> > without it they can't start. Don't know whether there are existing
> > bug-reports in Wine referring this, but there's open bug report in
> > ReactOS project tracker:
> > https://jira.reactos.org/browse/CORE-10426
>
> OK. There are still two more problems. First, the patch does not compile:
>
> rasapi.c: In function ‘RasGetConnectionStatistics’:
> rasapi.c:554:12: error: ‘ERROR_UNKNOWN’ undeclared (first use in this
> function); did you mean ‘DRIVE_UNKNOWN’?
>      return ERROR_UNKNOWN;
>             ^~~~~~~~~~~~~
>             DRIVE_UNKNOWN
>
> It looks like you forgot to include the change to raserror.h that was
> included in your Wine Staging patch:
> https://github.com/wine-compholio/wine-staging/blob/master/patches/rasapi32-...
>
> Second, you need to include a Signed-off-by line in your commit
> message. See https://wiki.winehq.org/Submitting_Patches#The_commit_message
>
> -Alex

[Alex Henrie]

2017-11-22 11:19 GMT-07:00 Станислав Мотыльков <x86corez(a)gmail.com>:
> Indeed, that change in header file was done by Sebastian Lackner, he
> accepted my patch in Wine Staging:
> https://dev.wine-staging.com/patches/203/
>
> Attached my updated patch.

Great! By the way, I noticed that you put RasGetConnectionStatistics
between RasGetAutodialParamW and RasGetConnectResponse in the
specfile. I'm not sure it matters, but I think it should go between
RasGetConnectStatusWow and RasGetCountryInfoA.
> Also can you advice whether this is ok to send patch that already was
> submitted to Wine Staging, should I wait for it or it is normal to go
> forward?

Patches are not automatically pulled into Wine from Wine Staging. It's
best to submit the patch to Wine yourself as you just did.

-Alex

[Станислав Мотыльков]

> I'm not sure it matters, but I think it should go between
> RasGetConnectStatusWow and RasGetCountryInfoA.

Yeah, looks like the functions are sorted alphabetically, let it be
so, I updated my patch again.

Thanks!

Regards,
Stas'M.

On 11/22/17, Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> 2017-11-22 11:19 GMT-07:00 Станислав Мотыльков <x86corez(a)gmail.com>:
> > Indeed, that change in header file was done by Sebastian Lackner, he
> > accepted my patch in Wine Staging:
> > https://dev.wine-staging.com/patches/203/
> >
> > Attached my updated patch.
>
> Great! By the way, I noticed that you put RasGetConnectionStatistics
> between RasGetAutodialParamW and RasGetConnectResponse in the
> specfile. I'm not sure it matters, but I think it should go between
> RasGetConnectStatusWow and RasGetCountryInfoA.
> > Also can you advice whether this is ok to send patch that already was
> > submitted to Wine Staging, should I wait for it or it is normal to go
> > forward?
>
> Patches are not automatically pulled into Wine from Wine Staging. It's
> best to submit the patch to Wine yourself as you just did.
>
> -Alex

[Alex Henrie]

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com>