Re: [4/6] secur32: Return PRF algorithm value when using GCM. (resend)

[Michael Müller]

This patch broke the compilation on Debian Wheezy and Ubuntu Trusty:

schannel_gnutls.c: In function schannel_get_mac_algid:
schannel_gnutls.c:329:10: error: ‘GNUTLS_MAC_AEAD undeclared (first use in this function)
schannel_gnutls.c:329:10: note: each undeclared identifier is reported only once for each function it appears in

Build overview: https://dev.wine-staging.com/builder/group/60/ (Click Downloads for build logs)
Debian Wheezy build log: https://builds.wine-staging.com/2017-04-27-21-23-02-job-10597/build.log

Regards,
Michael

[4/6] secur32: Return PRF algorithm value when using GCM. (resend)

[Bruno Jesus]

On Thu, Apr 27, 2017 at 8:27 PM, Michael Müller <michael(a)fds-team.de> wrote:
> This patch broke the compilation on Debian Wheezy and Ubuntu Trusty:
>
> schannel_gnutls.c: In function schannel_get_mac_algid:
> schannel_gnutls.c:329:10: error: ‘GNUTLS_MAC_AEAD undeclared (first use in this function)
> schannel_gnutls.c:329:10: note: each undeclared identifier is reported only once for each function it appears in
>
> Build overview: https://dev.wine-staging.com/builder/group/60/ (Click Downloads for build logs)
> Debian Wheezy build log: https://builds.wine-staging.com/2017-04-27-21-23-02-job-10597/build.log

PC-BSD 9 broke too, same error.

[4/6] secur32: Return PRF algorithm value when using GCM. (resend)

[Jacek Caban]

On 4/28/17 2:19 AM, Bruno Jesus wrote:
> On Thu, Apr 27, 2017 at 8:27 PM, Michael Müller <michael(a)fds-team.de> wrote:
> > This patch broke the compilation on Debian Wheezy and Ubuntu Trusty:
> >
> > schannel_gnutls.c: In function schannel_get_mac_algid:
> > schannel_gnutls.c:329:10: error: ‘GNUTLS_MAC_AEAD undeclared (first use in this function)
> > schannel_gnutls.c:329:10: note: each undeclared identifier is reported only once for each function it appears in
> >
> > Build overview: https://dev.wine-staging.com/builder/group/60/ (Click Downloads for build logs)
> > Debian Wheezy build log: https://builds.wine-staging.com/2017-04-27-21-23-02-job-10597/build.log
> > PC-BSD 9 broke too, same error.

Please verify that the attached patch fixes the problem.

Thanks,
Jacek

[4/6] secur32: Return PRF algorithm value when using GCM. (resend)

[Bruno Jesus]

On Fri, Apr 28, 2017 at 5:21 AM, Jacek Caban <jacek(a)codeweavers.com> wrote:
> On 4/28/17 2:19 AM, Bruno Jesus wrote:
> > On Thu, Apr 27, 2017 at 8:27 PM, Michael Müller <michael(a)fds-team.de>
> > wrote:
> > > This patch broke the compilation on Debian Wheezy and Ubuntu Trusty:
> > >
> > > schannel_gnutls.c: In function schannel_get_mac_algid:
> > > schannel_gnutls.c:329:10: error: ‘GNUTLS_MAC_AEAD undeclared (first use
> > > in this function)
> > > schannel_gnutls.c:329:10: note: each undeclared identifier is reported
> > > only once for each function it appears in
> > >
> > > Build overview: https://dev.wine-staging.com/builder/group/60/ (Click
> > > Downloads for build logs)
> > > Debian Wheezy build log:
> > > https://builds.wine-staging.com/2017-04-27-21-23-02-job-10597/build.log
> >
> > PC-BSD 9 broke too, same error.
>
> Please verify that the attached patch fixes the problem.

Yes, it fixes the problem.

Thanks,
Bruno

[4/6] secur32: Return PRF algorithm value when using GCM. (resend)

[Sebastian Lackner]

On 28.04.2017 14:58, Bruno Jesus wrote:
> On Fri, Apr 28, 2017 at 5:21 AM, Jacek Caban <jacek(a)codeweavers.com> wrote:
> > On 4/28/17 2:19 AM, Bruno Jesus wrote:
> > > On Thu, Apr 27, 2017 at 8:27 PM, Michael Müller <michael(a)fds-team.de>
> > > wrote:
> > > > This patch broke the compilation on Debian Wheezy and Ubuntu Trusty:
> > > >
> > > > schannel_gnutls.c: In function schannel_get_mac_algid:
> > > > schannel_gnutls.c:329:10: error: ‘GNUTLS_MAC_AEAD undeclared (first use
> > > > in this function)
> > > > schannel_gnutls.c:329:10: note: each undeclared identifier is reported
> > > > only once for each function it appears in
> > > >
> > > > Build overview: https://dev.wine-staging.com/builder/group/60/ (Click
> > > > Downloads for build logs)
> > > > Debian Wheezy build log:
> > > > https://builds.wine-staging.com/2017-04-27-21-23-02-job-10597/build.log
> > >
> > > PC-BSD 9 broke too, same error.
> >
> > Please verify that the attached patch fixes the problem.
>
> Yes, it fixes the problem.
>
> Thanks,
> Bruno

It also fixes the problem on Debian Wheezy, thanks!
See: https://dev.wine-staging.com/builder/group/61/

Please note that you can also start test builds yourself after
registering an account and requesting build server access.

Best regards,
Sebastian

[4/6] secur32: Return PRF algorithm value when using GCM. (resend)

[Akihiro Sagawa]

On Fri, 28 Apr 2017 15:06:15 +0200, Sebastian Lackner wrote:
> On 28.04.2017 14:58, Bruno Jesus wrote:
> > On Fri, Apr 28, 2017 at 5:21 AM, Jacek Caban <jacek(a)codeweavers.com> wrote:
> > > On 4/28/17 2:19 AM, Bruno Jesus wrote:
> > > > On Thu, Apr 27, 2017 at 8:27 PM, Michael Müller <michael(a)fds-team.de>
> > > > wrote:
> > > > > This patch broke the compilation on Debian Wheezy and Ubuntu Trusty:
> > > > >
> > > > > schannel_gnutls.c: In function schannel_get_mac_algid:
> > > > > schannel_gnutls.c:329:10: error: ‘GNUTLS_MAC_AEAD undeclared (first use
> > > > > in this function)
> > > > > schannel_gnutls.c:329:10: note: each undeclared identifier is reported
> > > > > only once for each function it appears in
> > > > >
> > > > > Build overview: https://dev.wine-staging.com/builder/group/60/ (Click
> > > > > Downloads for build logs)
> > > > > Debian Wheezy build log:
> > > > > https://builds.wine-staging.com/2017-04-27-21-23-02-job-10597/build.log
> > > >
> > > > PC-BSD 9 broke too, same error.
> > >
> > > Please verify that the attached patch fixes the problem.
> >
> > Yes, it fixes the problem.
> >
> > Thanks,
> > Bruno
>
> It also fixes the problem on Debian Wheezy, thanks!
> See: https://dev.wine-staging.com/builder/group/61/

I appreciate reporting and quick fixing for the issue.
I'll be more careful about an older version of GnuTLS.
And sorry for delaied response.

Regards,
Akihiro Sagawa