Re: PATCH: wine_dbgstr_an()

[Andreas Mohr]

On Tue, Oct 16, 2001 at 10:58:01PM +0200, Johan Gill wrote:
> Relay tracing would crash if it came upon a function call with an invalid
> pointer as a parameter.
> +	return "(invalid)";

Hmm, is there any reason why you just return "(invalid)" ?

IMHO this can be very misleading, as some programs use strings such as
"invalid", "NOT_VALID" or whatever to have something to compare against
to check for a valid return.
Furthermore it doesn't indicate at all that this string content originates
from within wine due to an invalid function argument.
I'd use something like: "WINE RELAY: invalid string pointer !" or so.
And, even better, sprintf() the string pointer value into a static buffer
to be used as a replacement, so that the output of this buffer looks like:
"WINE RELAY: invalid string pointer 0x00045213 !".

-- 
Andreas Mohr                        Stauferstr. 6, D-71272 Renningen, Germany
Tel. [phone]                http://home.nexgo.de/andi.mohr/