Re: [5/5] wined3d: Fix NaN and Inf generation in msvc

[Henri Verbeet]

On 31 July 2010 08:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> This workaround isn't ideal,
> Yeah, I don't think this is much of an improvement.

[5/5] wined3d: Fix NaN and Inf generation in msvc

[GOUJON Alexandre]

On 08/02/2010 12:00 PM, Henri Verbeet wrote:
> On 31 July 2010 08:48, Stefan Dösinger<stefan(a)codeweavers.com>  wrote:
> > This workaround isn't ideal,
>
> Yeah, I don't think this is much of an improvement

Why don't you use math.h NAN macro ?
A quick search on google gave me 
http://www.gnu.org/software/libc/manual//html_node/Infinity-and-NaN.html

[5/5] wined3d: Fix NaN and Inf generation in msvc

[Henri Verbeet]

On 2 August 2010 13:20, GOUJON Alexandre <ale.goujon(a)gmail.com> wrote:
> Why don't you use math.h NAN macro ?
> A quick search on google gave me
> http://www.gnu.org/software/libc/manual//html_node/Infinity-and-NaN.html

That's not portable enough.

[5/5] wined3d: Fix NaN and Inf generation in msvc

[Vitaly Budovski]

On 02/08/2010, Henri Verbeet <hverbeet(a)gmail.com> wrote:
> On 2 August 2010 13:20, GOUJON Alexandre <ale.goujon(a)gmail.com> wrote:
> > Why don't you use math.h NAN macro ?
> > A quick search on google gave me
> > http://www.gnu.org/software/libc/manual//html_node/Infinity-and-NaN.html
>
> That's not portable enough.

The INFINITY macro is part of C99, but for NaN, why not use something
like sqrt(-1) ?

[5/5] wined3d: Fix NaN and Inf generation in msvc

[Stefan Dösinger]

Am 03.08.2010 um 02:47 schrieb Vitaly Budovski:
> The INFINITY macro is part of C99, but for NaN, why not use something
> like sqrt(-1) ?
> We don't use C99 features in Wine, some compilers don't support them.

sqrt(-1) may or may not work, but it will be essentially the same as 0.0 / 0.0. Compilers may complain about sqrt(-1) just as they do with the 0.0 / 0.0 division.