[PATCH] windowscodecs: Fix a MsVC warning about get_decoder_info().
"...\info.c(2163) : warning C4028: formal parameter 1 different from declaration" ReactOS-Bug: https://jira.reactos.org/browse/CORE-7538 Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr> --- This is the first patch I submit to Wine... --- dlls/windowscodecs/info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/windowscodecs/info.c b/dlls/windowscodecs/info.c index 21e6610..e131107 100644 --- a/dlls/windowscodecs/info.c +++ b/dlls/windowscodecs/info.c @@ -2155,7 +2155,7 @@ void ReleaseComponentInfos(void) IWICComponentInfo_Release(&info->IWICComponentInfo_iface); } -HRESULT get_decoder_info(const CLSID *clsid, IWICBitmapDecoderInfo **info) +HRESULT get_decoder_info(REFCLSID clsid, IWICBitmapDecoderInfo **info) { IWICComponentInfo *compinfo; HRESULT hr; -- 2.10.0.windows.1
There's no reason this shouldn't be const. I think the header should be changed instead.
On 12/07/2018 17:45, Vincent Povirk wrote:
There's no reason this shouldn't be const. I think the header should be changed instead.
Your comment confuses me. Changing .c adds const to the pointer itself, changing .h would remove it, wouldn't it? See https://source.winehq.org/git/wine.git/blob/acb879c9d2feae69e8b5b1ede28523a2... --
Oh, I was looking at the definition in wtypes.idl, but I didn't check the context which shows that it isn't used. In that case, I don't see a meaningful distinction, so I guess we can do it either way.
participants (2)
-
Serge Gautherie -
Vincent Povirk