Re: [PATCH] wmvcore.c: Implement WMCreateReaderPriv

[Bruno Jesus]

On Wed, Feb 1, 2017 at 11:35 PM, Jefferson Carpenter
<jeffersoncarpenter2(a)gmail.com> wrote:
> -HRESULT WINAPI WMCreateReader(IUnknown *reserved, DWORD rights, IWMReader **ret_reader)
> +HRESULT WINAPI WMCreateReaderPriv(IWMReader **ret_reader)
>  {
>      WMReader *reader;
>
> -    TRACE("(%p, %x, %p)\n", reserved, rights, ret_reader);
> -
>      reader = heap_alloc(sizeof(*reader));
>      if(!reader)
>          return E_OUTOFMEMORY;
> @@ -667,6 +665,13 @@ HRESULT WINAPI WMCreateReader(IUnknown *reserved, DWORD rights, IWMReader **ret_
>      return S_OK;
>  }

IMO it's better to not change the original function, make the newer
function call WMCreateReader passing NULL reserved and 0 for rights.
> +HRESULT WINAPI WMCreateReader(IUnknown *reserved, DWORD rights, IWMReader **ret_reader)
> +{
> +    TRACE("(%p, %x, %p)\n", reserved, rights, ret_reader);
> +
> +       return WMCreateReaderPriv(ret_reader);
> +}
> +

You are mixing spaces and tabs, please use the most common style from the file.