Re: comctl32: theming "framework"

[Frank Richter]

On 16.07.2005 01:13, Frank Richter wrote:
> Frank Richter <frank.richter(a)gmail.com>
> Added some generic code to allow subclassing(for the purpose of theming)
> of standard controls.

What are the issues with this one?

-f.r.

comctl32: theming "framework"

[Alexandre Julliard]

Frank Richter <frank.richter(a)gmail.com> writes:
> On 16.07.2005 01:13, Frank Richter wrote:
> > Frank Richter <frank.richter(a)gmail.com>
> > Added some generic code to allow subclassing(for the purpose of theming)
> > of standard controls.
>
> What are the issues with this one?

I don't think you should store information in the class/window extra
data, since you have no way of knowing what offset to use. Basing the
offset on the total number of allocated bytes will break if someone
creates a new subclass with more extra data.

-- 
Alexandre Julliard
julliard(a)winehq.org