Re: [ws2_32] in some cases send should block until the entire buffer is sent

[Alexandre Julliard]

"Damjan Jovanovic" <damjan.jov(a)gmail.com> writes:
> +                                }
> +                                else
> +                                    skip("CreateThread failed, error %d\n", GetLastError());
> +                                closesocket(dst);
> +                            }
> +                            else
> +                                skip("accept failed, error %d\n", WSAGetLastError());
> +                        }
> +                        else
> +                            skip("connect failed, error %d\n", WSAGetLastError());
> +                    }
> +                    else
> +                        skip("listen failed, error %d\n", WSAGetLastError());
> +               }
> +               else
> +                   skip("getsockname failed, error %d\n", WSAGetLastError());
> +            }
> +            else
> +                skip("bind failed, error %d\n", WSAGetLastError());
> +            closesocket(server);
> +        }
> +        else
> +            skip("creating socket failed, error %d\n", WSAGetLastError());
> +        closesocket(src);
> +    }
> +    else
> +        skip("creating socket failed, error %d\n", WSAGetLastError());

This isn't an appropriate use of skip(), these things are not supposed
to fail, and if they do something is broken. You should use ok()
here. And please avoid the ugly nested ifs, use return or goto end.

-- 
Alexandre Julliard
julliard(a)winehq.org