[PATCH v4 5/5] kernelbase: Reimplement GetVolumeInformation on top of GetVolumeInformationByHandle.
This patch removes the volume querying information duplication in kernelbase by re-implementing GetVolumeInformation using GetVolumeInformationByHandle (itself implemented with NtQueryVolumeInformationFile). v4: Reordered (no content change) v3: No change v2: Reordered (no content change) Best, Erich
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=81138 Your paranoid android. === debiant (32 bit Chinese:China report) === kernel32: volume.c:540: Test failed: GetVolumeInformationA failed, root=\\?\Volume{00000000-0000-0000-0000-000000000043}\, last error=997
On Wed, Oct 28, 2020 at 3:53 PM Marvin <testbot(a)winehq.org> wrote:
... === debiant (32 bit Chinese:China report) ===
kernel32: volume.c:540: Test failed: GetVolumeInformationA failed, root=\\?\Volume{00000000-0000-0000-0000-000000000043}\, last error=997
I'm struggling to reproduce this locally. Is there a page that describes the "debiant (wow64)" testbot configuration? I've tried: runtest -P wine -p kernel32_test.exe volume in both my 64-bit and 32-bit build directories and I'm not seeing this show up. I don't believe this appeared the last time I submitted, is this a new configuration? Best, Erich
participants (2)
-
Erich E. Hoover -
Marvin