Re: [PATCH 1/2] Patch for bug 20227
21 Oct
2009
21 Oct
'09
3:18 p.m.
Hi Nate, the subject line isn't specific enough. We'd prefer you put a brief description of the change, rather than the bug that motivated it. E.g. your git commit tag for this, "Add tablename tracking to VIEW_find_column.", would be better. For your patch 2/2, you used "Test for bug 20227" as the git commit, which really isn't descriptive enough. Thanks. (Also, nit:
irregardless of any tablename modifier. irregardless is not a word. You probably mean either regardless or irrespective.) --Juan
5899
Age (days ago)
5899
Last active (days ago)
0 comments
1 participants
participants (1)
-
Juan Lang