Re: [2/4](resend)strmbase: implement BaseControlWindow

[Nikolay Sivov]

On 3/16/2012 04:00, Aric Stewart wrote:
> +HRESULT WINAPI BaseControlWindowImpl_GetTypeInfo(IVideoWindow *iface, UINT iTInfo, LCID lcid, ITypeInfo**ppTInfo)
> +{
> +    BaseControlWindow*  This = (BaseControlWindow*)iface;
> +
> It doesn't look like a normal COM interface (lack of refcount for 
> example, and corresponding IUnknown support), but I think it's still 
> better to use a cleaner way to get impl pointer like all others do now - 
> with impl_from_*() functions.

[2/4](resend)strmbase: implement BaseControlWindow

[Aric Stewart]

On 3/16/12 12:36 AM, Nikolay Sivov wrote:
> On 3/16/2012 04:00, Aric Stewart wrote:
> > +HRESULT WINAPI BaseControlWindowImpl_GetTypeInfo(IVideoWindow *iface,
> > UINT iTInfo, LCID lcid, ITypeInfo**ppTInfo)
> > +{
> > + BaseControlWindow* This = (BaseControlWindow*)iface;
> > +
> > It doesn't look like a normal COM interface (lack of refcount for
> > example, and corresponding IUnknown support), but I think it's still
> > better to use a cleaner way to get impl pointer like all others do now -
> > with impl_from_*() functions.

It is not COM but still based off of C++ so it has similar feel to it. I 
can rewrite to use the impl_from functions.

Thanks!
-aric