[PATCH] wininet/tests: Increase the maximum expected available data value.

[Francois Gouget]

With each Windows version InternetQueryDataAvailable() reports a
different value. 8192 from XP/2003 to Vista/2008; then 1460 from
Windows 7 to Windows 10 1709; and 24000 starting with Windows 10 1809.

Signed-off-by: Francois Gouget <fgouget(a)free.fr>
---

This fixes a failure on Windows 10 1809. I'm not entirely sure it makes 
sense to check for this value. If we do, maybe we should leave a 
bigger margin? Like < 31000? Not that it did us much good last time...

Also, shouldn't we check that it is greater than some minimum value? 
Like at least 1000?

References:
https://test.winehq.org/data/190fb605c34ac1365076dff0a6560ddb42ca1ef2/index_...
Look for the entries with 4 failures.

https://testbot.winehq.org/JobDetails.pl?Key=60767
Look for the 'avail=' traces.

 dlls/wininet/tests/http.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c
index c7472c7ea09..a72c9ed0518 100644
--- a/dlls/wininet/tests/http.c
+++ b/dlls/wininet/tests/http.c
@@ -5549,9 +5549,9 @@ static void test_http_read(int port)
     readex_expect_sync_data(req.request, IRF_NO_WAIT, &ib, sizeof(buf), "123", 0);
     readex_expect_async(req.request, IRF_NO_WAIT, &ib, sizeof(buf), NULL);
 
-    send_response_len_and_wait(20000, TRUE, &ib);
+    send_response_len_and_wait(32000, TRUE, &ib);
     avail = expect_data_available(req.request, -1);
-    ok(avail < 17000, "avail = %u\n", avail);
+    ok(avail < 25000, "avail = %u\n", avail);
 
     SET_WINE_ALLOW(INTERNET_STATUS_CLOSING_CONNECTION);
     SET_WINE_ALLOW(INTERNET_STATUS_CONNECTION_CLOSED);
-- 
2.20.1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=61054

Your paranoid android.


=== debian10 (32 bit report) ===

wininet:
http.c:4946: Test failed: expected 1 pending read, got 2

=== debian10 (32 bit Japanese:Japan report) ===

wininet:
http.c:5034: Test failed: expected 1 pending read, got 2

[Jacek Caban]

Hi Francois,

On 11/28/19 1:41 PM, Francois Gouget wrote:
> With each Windows version InternetQueryDataAvailable() reports a
> different value. 8192 from XP/2003 to Vista/2008; then 1460 from
> Windows 7 to Windows 10 1709; and 24000 starting with Windows 10 1809.
>
> Signed-off-by: Francois Gouget <fgouget(a)free.fr>
> ---
>
> This fixes a failure on Windows 10 1809. I'm not entirely sure it makes
> sense to check for this value. If we do, maybe we should leave a
> bigger margin? Like < 31000? Not that it did us much good last time...

Maybe we should use a significantly higher value in hope that we will 
not have to increase it with the next Windows update? The exact value is 
not important, the point is that not whole data is reported when amount 
of pending data is large enough.
> Also, shouldn't we check that it is greater than some minimum value?
> Like at least 1000?

Sure, sounds good.


Thanks,

Jacek