Re: shell32: Fix cast in RecycleBinMenu_InvokeCommand

[Alexandre Julliard]

Jay Yang <jkelleyy(a)gmail.com> writes:
> @@ -240,7 +240,7 @@ static HRESULT WINAPI RecycleBinMenu_InvokeCommand(IContextMenu2 *iface,
>      LPCSTR verb = pici->lpVerb;
>      if(!HIWORD(verb))
>      {
> -        switch((UINT)verb)
> +        switch((UINT_PTR)verb)

Actually the HIWORD() is more problematic.

-- 
Alexandre Julliard
julliard(a)winehq.org

shell32: Fix cast in RecycleBinMenu_InvokeCommand

[Jay Yang]

On 07/14/2011 09:50 AM, Alexandre Julliard wrote:
> Jay Yang <jkelleyy(a)gmail.com> writes:
> > @@ -240,7 +240,7 @@ static HRESULT WINAPI RecycleBinMenu_InvokeCommand(IContextMenu2 *iface,
> >      LPCSTR verb = pici->lpVerb;
> >      if(!HIWORD(verb))
> >      {
> > -        switch((UINT)verb)
> > +        switch((UINT_PTR)verb)
> > Actually the HIWORD() is more problematic.

What's the best way to do this then. Since the msdn documentation on this assumes that pointers are
32 bit, which is obviously wrong. Should I do something like "if((verb&0xFFFF)==verb)"?

--
Jay Yang