Crash bug in Wine 1.3.5 in advapi32/service.c

[Damian Dixon]

Hi,

In file dlls/advapi32/service.c, line 1135 a memory copy occurs, however the
lpservicestatus is not checked to see if the value is NULL.

This causes a crash in an application that has worked before under wine.

My naive change is:

    if (ret && lpservicestatus) memcpy(lpservicestatus, &SvcStatusData,
sizeof(SERVICE_STATUS)) ;

Regards
Damian

[Hans Leidekker]

On Fri, 2010-10-29 at 17:55 +0100, Damian Dixon wrote:
> In file dlls/advapi32/service.c, line 1135 a memory copy occurs,
> however the lpservicestatus is not checked to see if the value is
> NULL.
>
> This causes a crash in an application that has worked before under
> wine.
>
> My naive change is:
>
> if (ret && lpservicestatus) memcpy(lpservicestatus, &SvcStatusData,

It's more likely that QueryServiceStatus returns failure when
lpservicestatus is NULL. Please open a bug for this and the other
problem you observed.