Repetitve fixme for each file accessed.

[Segin]

I keep getting stub fixme's for each and every single file that is 
access in Wine, especially via an installer. THe fixmes look like:

fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\GeneXproTools 
4\\SampleRuns\\XOR.gep") stub

Does this have anything to do with the ClamAV integration I've heard you 
guys talking about?

-- 
The real problem with C++ for kernel modules is: the language just sucks.
	-- Linus Torvalds

[Detlef Riekenberg]

Segin wrote:
> fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\GeneXproTools 
> 4\\SampleRuns\\XOR.gep") stub

This indicates, that the Installer is correct.
When an Installer does not give the fixme, it's outdated / incomplete.
> Does this have anything to do with the ClamAV integration I've heard you 
> guys talking about?

No. ":sfc:" is the dllname, and when you look at the only source-file,
you will find:

 * Implementation of the System File Checker (Windows File Protection)

(I added this to wine)

-- 
By By ...
      ... Detlef

[Dan Kegel]

On 7/24/06, Detlef Riekenberg <wine.dev(a)web.de> wrote:
> Segin wrote:
> > fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\GeneXproTools
> > 4\\SampleRuns\\XOR.gep") stub
>
> (I added this to wine)

Please turn it into a TRACE instead of a FIXME.

[Kuba Ober]

> > > fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\GeneXproTools
> > > 4\\SampleRuns\\XOR.gep") stub
> >
> > (I added this to wine)
>
> Please turn it into a TRACE instead of a FIXME.

If it's a stub isn't it a FIXME? Otherwise it'd only make sense to me if it 
were a long-term WONTFIX type of thing. Or if it's not a stub anymore then of 
course you're right and it needs to be merely a trace.

Cheers, Kuba

[Dan Kegel]

On 7/24/06, Kuba Ober <kuba(a)mareimbrium.org> wrote:
> > > > fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\GeneXproTools
> > > > 4\\SampleRuns\\XOR.gep") stub
> >
> > Please turn it into a TRACE instead of a FIXME.
>
> If it's a stub isn't it a FIXME?

That is standard practice for extremely intrusive and frequent FIXME's, I think.
It's a practical thing.

[Stefan Dösinger]

Am Dienstag 25 Juli 2006 00:15 schrieb Dan Kegel:
> On 7/24/06, Kuba Ober <kuba(a)mareimbrium.org> wrote:
> > > > > fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program
> > > > > Files\\GeneXproTools 4\\SampleRuns\\XOR.gep") stub
> > >
> > > Please turn it into a TRACE instead of a FIXME.
> >
> > If it's a stub isn't it a FIXME?
>
> That is standard practice for extremely intrusive and frequent FIXME's, I
> think. It's a practical thing.
> why not print the fixme once?

static BOOL warned = FALSE;
if(!warned) {
    FIXME("Stub!\n");
    warned = TRUE;
}

[Kuba Ober]

> > > > > fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program
> > > > > Files\\GeneXproTools 4\\SampleRuns\\XOR.gep") stub
> > >
> > > Please turn it into a TRACE instead of a FIXME.
> >
> > If it's a stub isn't it a FIXME?
>
> That is standard practice for extremely intrusive and frequent FIXME's, I
> think. It's a practical thing.

Gotcha. Thanks for the explanation. Makes sense.

Kuba