Re: [dxdiagn] Implemented retrieval of b3DAccelerationEnabled property
Markus wrote:
------------------------------------------------------------------------
+ HKEY key_handle; + LPCSTR searchSubKey = "SOFTWARE\\Microsoft\\DirectDraw"; + LPCSTR dataSubKey = "EmulationOnly";
I don't see anywhere Wine using this key. How did you came up with this key?
+ V_VT(&v) = VT_BOOL; V_BOOL(&v) = get_ddraw_acceleration(); + IDxDiagContainerImpl_AddProp( pDisplayAdapterSubCont, b3DAccelerationEnabled, &v ); + VariantClear(&v); Why don't you use add_prop_bool()?
Vitaliy
On Mo, 2009-01-12 at 09:50 -0700, Vitaliy Margolen wrote:
+ LPCSTR searchSubKey = "SOFTWARE\\Microsoft\ \DirectDraw"; + LPCSTR dataSubKey = "EmulationOnly"; I don't see anywhere Wine using this key. How did you came up with this key?
That was me. On his questions, how to to get usable date for b3DAccelerationExists and b3DAccelerationEnabled, i remember, that dxdiag can be used to enable/disable Accelleration. I fired up regedit and dxdiag on W98 and searched for a Key, where the enable/disable state might be saved, while switching the state in dxdiag. When using regedit to change the state, a restart of dxdiag showed the expected results. My comments are here: http://www.winehq.org/pipermail/wine-devel/2009-January/071853.html -- By by ... Detlef
On Monday 12 January 2009 11:50:27 Vitaliy Margolen wrote:
Markus wrote:
+ V_VT(&v) = VT_BOOL; V_BOOL(&v) = get_ddraw_acceleration(); + IDxDiagContainerImpl_AddProp( pDisplayAdapterSubCont, b3DAccelerationEnabled, &v ); + VariantClear(&v);
Why don't you use add_prop_bool()?
That was an oversight. I'll change the code in both files. Are there any other objections to the patches? http://www.winehq.org/pipermail/wine-patches/2009-January/067437.html http://www.winehq.org/pipermail/wine-patches/2009-January/067463.html -- Markus
participants (3)
-
Detlef Riekenberg -
Markus -
Vitaliy Margolen