Re: hhctrl: Correctly draw the navigation pane

[Robert Shearman]

James Hawkins wrote:
> Hi,
>
> Changelog
> * Correctly draw the navigation pane.

Hi James,

I'm impressed with the work that has been done to get hhctrl this 
complete. But...
> @@ -149,7 +144,7 @@ static void HH_RegisterChildWndClass(HHI
>     wcex.hInstance      = pHHInfo->hInstance;
>     wcex.hIcon          = LoadIconW(NULL, (LPCWSTR)IDI_APPLICATION);
>     wcex.hCursor        = LoadCursorW(NULL, (LPCWSTR)IDC_ARROW);
> -    wcex.hbrBackground  = (HBRUSH)(COLOR_3DFACE);
> +    wcex.hbrBackground  = (HBRUSH)(COLOR_MENU);

This doesn't seem right. You're not registering a menu-like class.
> wcex.lpszMenuName   = NULL;
>     wcex.lpszClassName  = szChildClass;
>     wcex.hIconSm        = LoadIconW(NULL, (LPCWSTR)IDI_APPLICATION);

-- 
Rob Shearman

hhctrl: Correctly draw the navigation pane

[Dmitry Timoshkov]

"Robert Shearman" <rob(a)codeweavers.com> wrote:
> > @@ -149,7 +144,7 @@ static void HH_RegisterChildWndClass(HHI
> >     wcex.hInstance      = pHHInfo->hInstance;
> >     wcex.hIcon          = LoadIconW(NULL, (LPCWSTR)IDI_APPLICATION);
> >     wcex.hCursor        = LoadCursorW(NULL, (LPCWSTR)IDC_ARROW);
> > -    wcex.hbrBackground  = (HBRUSH)(COLOR_3DFACE);
> > +    wcex.hbrBackground  = (HBRUSH)(COLOR_MENU);
>
> This doesn't seem right. You're not registering a menu-like class.

Moreover, when using COLOR_xxx constants in the place of a brush one
needs to increase the value by 1 in order to make it work.

dlls/msi/dialog.c, dlls/shlwapi/ordinal.c, programs/notepad/main.c
have the same problem.

-- 
Dmitry.