Re: [v2 PATCH 2/3] d2d1/tests: Basic test for ID2D1DCRenderTarget creation
On 29 March 2016 at 01:21, Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
+ static D2D1_PIXEL_FORMAT invalid_formats[] = + { + { DXGI_FORMAT_UNKNOWN, D2D1_ALPHA_MODE_PREMULTIPLIED }, + { DXGI_FORMAT_B8G8R8A8_UNORM, D2D1_ALPHA_MODE_UNKNOWN }, + { DXGI_FORMAT_R8G8B8A8_UNORM, D2D1_ALPHA_MODE_PREMULTIPLIED }, + }; I should have noticed before, but this should be const.
On 29.03.2016 12:15, Henri Verbeet wrote:
On 29 March 2016 at 01:21, Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
+ static D2D1_PIXEL_FORMAT invalid_formats[] = + { + { DXGI_FORMAT_UNKNOWN, D2D1_ALPHA_MODE_PREMULTIPLIED }, + { DXGI_FORMAT_B8G8R8A8_UNORM, D2D1_ALPHA_MODE_UNKNOWN }, + { DXGI_FORMAT_R8G8B8A8_UNORM, D2D1_ALPHA_MODE_PREMULTIPLIED }, + }; I should have noticed before, but this should be const.
Thanks, I sent all 3 of them so testbot is not confused, only 2/3 was changed.
participants (2)
-
Henri Verbeet -
Nikolay Sivov