Re: [PATCH] ddrawex: use stack ctx instead of uninitialized variable

[Austin English]

On Mon, Jan 26, 2009 at 11:06 AM, Marcus Meissner <meissner(a)suse.de> wrote:
> ---
>  dlls/ddrawex/ddraw.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/dlls/ddrawex/ddraw.c b/dlls/ddrawex/ddraw.c
> index b581529..6607c78 100644
> --- a/dlls/ddrawex/ddraw.c
> +++ b/dlls/ddrawex/ddraw.c
> @@ -678,11 +678,11 @@ IDirectDraw4Impl_EnumSurfaces(IDirectDraw4 *iface,
>                               LPDDENUMSURFACESCALLBACK2 Callback)
>  {
>     IDirectDrawImpl *This = impl_from_dd4(iface);
> -    struct enumsurfaces4_ctx *ctx;
> +    struct enumsurfaces4_ctx ctx;
>     TRACE("(%p)->(0x%08x,%p,%p,%p)\n", This, Flags, DDSD, Context, Callback);
>
> -    ctx->orig_cb = Callback;
> -    ctx->orig_ctx = Context;
> +    ctx.orig_cb = Callback;
> +    ctx.orig_ctx = Context;
>     return IDirectDraw4Impl_EnumSurfaces(This->parent, Flags, DDSD, &ctx, enum_surfaces_wrapper);
>  }
>
> --
> 1.6.0.2

This fixes Coverity 867. Pointing out so that AJ can add that to the
patch title, so we can find it in the git log :-).

-- 
-Austin