Re: [PATCH] user32:add SIZEALL_BIG cursor, reusing SIZEALL resource Fixes bug#42303

[Alexandre Julliard]

Anton Romanov <theli.ua(a)gmail.com> writes:
> @@ -2227,6 +2227,7 @@ typedef struct tagCBTACTIVATESTRUCT
>  #define IDC_HAND           MAKEINTRESOURCE(32649)
>  #define IDC_APPSTARTING    MAKEINTRESOURCE(32650)
>  #define IDC_HELP           MAKEINTRESOURCE(32651)
> +#define IDC_SIZEALL_BIG    MAKEINTRESOURCE(32654)

There's no such definition in Windows.
> @@ -1011,6 +1011,7 @@
>  #define OCR_NO                 32648
>  #define OCR_HAND               32649
>  #define OCR_APPSTARTING        32650
> +#define OCR_SIZEALL_BIG        32654

This is already defined as OCR_RDR2DIM.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH] user32:add SIZEALL_BIG cursor, reusing SIZEALL resource Fixes bug#42303

[Anton Romanov]

On Thu, Jan 26, 2017 at 11:02 AM, Alexandre Julliard
<julliard(a)winehq.org> wrote:
> Anton Romanov <theli.ua(a)gmail.com> writes:
> > +#define IDC_SIZEALL_BIG    MAKEINTRESOURCE(32654)
>
> There's no such definition in Windows.
> Well, there is definitely cursor with ID 32654 in native user32.dll
> http://imgur.com/a/egVkt  but I couldn't find it being referenced in
> documentation. And there is at least 1 app that crashes with it
> absent.
> If this is not the right way to add it to user32.dll, please advice on
> a better one.

[PATCH] user32:add SIZEALL_BIG cursor, reusing SIZEALL resource Fixes bug#42303

[Anton Romanov]

On Thu, Jan 26, 2017 at 11:02 AM, Alexandre Julliard
<julliard(a)winehq.org> wrote:
> Anton Romanov <theli.ua(a)gmail.com> writes:
> > @@ -2227,6 +2227,7 @@ typedef struct tagCBTACTIVATESTRUCT
> >  #define IDC_HAND           MAKEINTRESOURCE(32649)
> >  #define IDC_APPSTARTING    MAKEINTRESOURCE(32650)
> >  #define IDC_HELP           MAKEINTRESOURCE(32651)
> > +#define IDC_SIZEALL_BIG    MAKEINTRESOURCE(32654)
>
> There's no such definition in Windows.
> > @@ -1011,6 +1011,7 @@
> >  #define OCR_NO                 32648
> >  #define OCR_HAND               32649
> >  #define OCR_APPSTARTING        32650
> > +#define OCR_SIZEALL_BIG        32654
>
> This is already defined as OCR_RDR2DIM.
> Alright, I've now drawn all OCR_RDR* cursors and submitted updated
> patch with them to use already defined OCR_RDR* defines.

Thanks!