Re: [PATCH 7/7] configure: disable fortify the right way

[Alexandre Julliard]

Marcus Meissner <marcus(a)jet.franken.de> writes:
> Hi,
>
> $EXTRACFLAGS is used before $CFLAGS, so the previous try would not work.
>
> Also just -U the define.

Won't this break if the default is set through a header? Do all distros
do this only through CFLAGS?

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 7/7] configure: disable fortify the right way

[Marcus Meissner]

On Sat, Oct 23, 2010 at 11:39:45AM +0200, Alexandre Julliard wrote:
> Marcus Meissner <marcus(a)jet.franken.de> writes:
> > Hi,
> >
> > $EXTRACFLAGS is used before $CFLAGS, so the previous try would not work.
> >
> > Also just -U the define.
>
> Won't this break if the default is set through a header? Do all distros
> do this only through CFLAGS?

Hmm.

openSUSE/SUSE sets it via RPM_OPT_FLAGS -> CFLAGS.

Unsure about Redhat.

Ciao, Marcus

[PATCH 7/7] configure: disable fortify the right way

[Charles Davis]

On 10/23/10 3:39 AM, Alexandre Julliard wrote:
> Marcus Meissner <marcus(a)jet.franken.de> writes:
> > Hi,
> >
> > $EXTRACFLAGS is used before $CFLAGS, so the previous try would not work.
> >
> > Also just -U the define.
>
> Won't this break if the default is set through a header? Do all distros
> do this only through CFLAGS?
> Nope. Mac OS sets it in <_types.h>:

#ifndef _FORTIFY_SOURCE
#  if defined(__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__) &&
((__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__-0) < 1050)
#    define _FORTIFY_SOURCE 0
#  else
#    define _FORTIFY_SOURCE 2   /* on by default */
#  endif
#endif

Chip

[PATCH 7/7] configure: disable fortify the right way

[Marcus Meissner]

On Sat, Oct 23, 2010 at 09:08:06AM -0600, Charles Davis wrote:
> On 10/23/10 3:39 AM, Alexandre Julliard wrote:
> > Marcus Meissner <marcus(a)jet.franken.de> writes:
> > > Hi,
> > >
> > > $EXTRACFLAGS is used before $CFLAGS, so the previous try would not work.
> > >
> > > Also just -U the define.
> >
> > Won't this break if the default is set through a header? Do all distros
> > do this only through CFLAGS?
> > Nope. Mac OS sets it in <_types.h>:
>
> #ifndef _FORTIFY_SOURCE
> #  if defined(__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__) &&
> ((__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__-0) < 1050)
> #    define _FORTIFY_SOURCE 0
> #  else
> #    define _FORTIFY_SOURCE 2   /* on by default */
> #  endif
> #endif

Then I would suggest adding to CFLAGS:

	-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0

Otherwise for CFLAGS="..." ./configure you get redefinition warnings
for every file.

Ciao, Marcus