Re: (retry) msctf/tests: handle an occassional unexpected SetFocus from wine

[Nicolas Le Cam]

2009/11/7 Aric Stewart <aric(a)codeweavers.com>:
> ---
>  dlls/msctf/tests/inputprocessor.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)

Here are the results for 100 consecutive runs :
$ for i in {1..100}; do wine msctf_test.exe.so >> msctf_tests.log 2>&1; done
$ grep "tests executed" msctf_tests.log | sort | uniq -c | sort -nr
     77 inputprocessor: 230 tests executed (0 marked as todo, 0
failures), 0 skipped.
     18 inputprocessor: 231 tests executed (0 marked as todo, 3
failures), 0 skipped.
      3 inputprocessor: 234 tests executed (0 marked as todo, 4
failures), 0 skipped.
      1 inputprocessor: 238 tests executed (0 marked as todo, 8
failures), 0 skipped.
      1 inputprocessor: 236 tests executed (0 marked as todo, 6
failures), 0 skipped.

I also did try to sleep between tests in case it could help but it
doesn't seem so :
$ for i in {1..100}; do wine msctf_test.exe.so >> msctf_tests.log
2>&1; sleep 1; done
$ grep "tests executed" msctf_tests.log | sort | uniq -c | sort -nr
     78 inputprocessor: 230 tests executed (0 marked as todo, 0
failures), 0 skipped.
     17 inputprocessor: 231 tests executed (0 marked as todo, 3
failures), 0 skipped.
      3 inputprocessor: 238 tests executed (0 marked as todo, 8
failures), 0 skipped.
      2 inputprocessor: 236 tests executed (0 marked as todo, 6
failures), 0 skipped.

For info, here is a run without your patch.
$ for i in {1..100}; do wine msctf_test.exe.so >> msctf_tests.log
2>&1; sleep 1; done
$ grep "tests executed" msctf_tests.log | sort | uniq -c | sort -nr
     64 inputprocessor: 230 tests executed (0 marked as todo, 0
failures), 0 skipped.
     18 inputprocessor: 236 tests executed (0 marked as todo, 4
failures), 0 skipped.
     12 inputprocessor: 237 tests executed (0 marked as todo, 7
failures), 0 skipped.
      3 inputprocessor: 234 tests executed (0 marked as todo, 4
failures), 0 skipped.
      2 inputprocessor: 236 tests executed (0 marked as todo, 6
failures), 0 skipped.
      1 inputprocessor: 238 tests executed (0 marked as todo, 8
failures), 0 skipped.

If you need me to do more tests, just ask, I'm willing to go green ;)

-- 
Nicolas Le Cam