[PATCH 1/3] msctf:return S_OK in TextStoreACPSink_OnTextChange

[Louis Lenders]

This is for bug 44404

Several .Net applications crash on these stubs returning E_NOTIMPL.
 Returning S_OK makes the crashes gone, up to now i`ve not seen this causes any unwanted side-effects/ no new crashes as far as I can tell.
Example of program that crashes quite quickly is installer of https://www.remembear.com/download/



Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com>
---
 dlls/msctf/context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msctf/context.c b/dlls/msctf/context.c
index 54052f6..70b06e2 100644
--- a/dlls/msctf/context.c
+++ b/dlls/msctf/context.c
@@ -758,7 +758,7 @@ static HRESULT WINAPI TextStoreACPSink_OnTextChange(ITextStoreACPSink *iface,
 {
     Context *This = impl_from_ITextStoreACPSink(iface);
     FIXME("STUB:(%p)\n",This);
-    return E_NOTIMPL;
+    return S_OK;
 }
 
 static HRESULT WINAPI TextStoreACPSink_OnSelectionChange(ITextStoreACPSink *iface)
-- 
2.7.4

[PATCH 2/3] msctf: return S_OK in TextStoreACPSink_OnSelectionChange

[Louis Lenders]

For bug 44404




Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com>
---
 dlls/msctf/context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msctf/context.c b/dlls/msctf/context.c
index 70b06e2..d52884d 100644
--- a/dlls/msctf/context.c
+++ b/dlls/msctf/context.c
@@ -765,7 +765,7 @@ static HRESULT WINAPI TextStoreACPSink_OnSelectionChange(ITextStoreACPSink *ifac
 {
     Context *This = impl_from_ITextStoreACPSink(iface);
     FIXME("STUB:(%p)\n",This);
-    return E_NOTIMPL;
+    return S_OK;
 }
 
 static HRESULT WINAPI TextStoreACPSink_OnLayoutChange(ITextStoreACPSink *iface,
-- 
2.7.4

[PATCH 2/3] msctf: return S_OK in TextStoreACPSink_OnSelectionChange

[Aric Stewart]

Signed-off-by: Aric Stewart <aric(a)codeweavers.com>

On 4/4/18 4:48 AM, Louis Lenders wrote:
> For bug 44404
>
> Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com>
> ---
>   dlls/msctf/context.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/msctf/context.c b/dlls/msctf/context.c
> index 70b06e2..d52884d 100644
> --- a/dlls/msctf/context.c
> +++ b/dlls/msctf/context.c
> @@ -765,7 +765,7 @@ static HRESULT WINAPI TextStoreACPSink_OnSelectionChange(ITextStoreACPSink *ifac
>   {
>       Context *This = impl_from_ITextStoreACPSink(iface);
>       FIXME("STUB:(%p)\n",This);
> -    return E_NOTIMPL;
> +    return S_OK;
>   }
>
> static HRESULT WINAPI TextStoreACPSink_OnLayoutChange(ITextStoreACPSink *iface,

[PATCH 3/3] msctf:return S_OK in TextStoreACPSink_OnLayoutChange

[Louis Lenders]

Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com>
---
 dlls/msctf/context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msctf/context.c b/dlls/msctf/context.c
index d52884d..452895c 100644
--- a/dlls/msctf/context.c
+++ b/dlls/msctf/context.c
@@ -773,7 +773,7 @@ static HRESULT WINAPI TextStoreACPSink_OnLayoutChange(ITextStoreACPSink *iface,
 {
     Context *This = impl_from_ITextStoreACPSink(iface);
     FIXME("STUB:(%p)\n",This);
-    return E_NOTIMPL;
+    return S_OK;
 }
 
 static HRESULT WINAPI TextStoreACPSink_OnStatusChange(ITextStoreACPSink *iface,
-- 
2.7.4

[PATCH 3/3] msctf:return S_OK in TextStoreACPSink_OnLayoutChange

[Aric Stewart]

Signed-off-by: Aric Stewart <aric(a)codeweavers.com>

On 4/4/18 4:48 AM, Louis Lenders wrote:
> Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com>
> ---
>   dlls/msctf/context.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/msctf/context.c b/dlls/msctf/context.c
> index d52884d..452895c 100644
> --- a/dlls/msctf/context.c
> +++ b/dlls/msctf/context.c
> @@ -773,7 +773,7 @@ static HRESULT WINAPI TextStoreACPSink_OnLayoutChange(ITextStoreACPSink *iface,
>   {
>       Context *This = impl_from_ITextStoreACPSink(iface);
>       FIXME("STUB:(%p)\n",This);
> -    return E_NOTIMPL;
> +    return S_OK;
>   }
>
> static HRESULT WINAPI TextStoreACPSink_OnStatusChange(ITextStoreACPSink *iface,

[Aric Stewart]

Signed-off-by: Aric Stewart <aric(a)codeweavers.com>

On 4/4/18 4:47 AM, Louis Lenders wrote:
> This is for bug 44404
>
> Several .Net applications crash on these stubs returning E_NOTIMPL.
>   Returning S_OK makes the crashes gone, up to now i`ve not seen this causes any unwanted side-effects/ no new crashes as far as I can tell.
> Example of program that crashes quite quickly is installer of https://www.remembear.com/download/
>
> Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com>
> ---
>   dlls/msctf/context.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/msctf/context.c b/dlls/msctf/context.c
> index 54052f6..70b06e2 100644
> --- a/dlls/msctf/context.c
> +++ b/dlls/msctf/context.c
> @@ -758,7 +758,7 @@ static HRESULT WINAPI TextStoreACPSink_OnTextChange(ITextStoreACPSink *iface,
>   {
>       Context *This = impl_from_ITextStoreACPSink(iface);
>       FIXME("STUB:(%p)\n",This);
> -    return E_NOTIMPL;
> +    return S_OK;
>   }
>
> static HRESULT WINAPI TextStoreACPSink_OnSelectionChange(ITextStoreACPSink *iface)