Re: oleaut32:typelib - Addresses VT_VOID bug in typedescvt_to_variantvt

[Robert Shearman]

Benjamin Arai wrote:
> From: Benjamin Arai <me(a)benjaminarai.com>
> Date: Wed, 12 Jul 2006 09:41:25 -0700
> Subject: [PATCH] The patch fixes a bug in oleaut32:typelib:typedescvt_to_variantvt VOID was not be accounted for
> ---
> dlls/oleaut32/typelib.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c
> index ce3a1dc..aa470f8 100644
> --- a/dlls/oleaut32/typelib.c
> +++ b/dlls/oleaut32/typelib.c
> @@ -5067,6 +5067,8 @@ static HRESULT typedescvt_to_variantvt(I
>         hr = userdefined_to_variantvt(tinfo, tdesc, vt);
>         break;
>     case VT_VOID:
> +        *vt |= VT_VOID;
> +        break;
>     case VT_CARRAY:
>     case VT_PTR:
>     case VT_LPSTR:

Hi Benjamin,

Thanks for sending the patch, but it isn't quite correct. VT_VOID is a 
typedesc variant type, which should be converted into the regular 
variant type of VT_EMPTY. This value is also only valid for return 
types. I've sent a patch to wine-patches that addresses both of these 
issues.

-- 
Rob Shearman