Re: [PATCH] Replace builtin WineFile Execute Dialog with standard RunFileDialog

[Dmitry Timoshkov]

"Steven Edwards" <winehacker(a)gmail.com> wrote:
> - Removed the LoadLibrary calls in favor of GetModuleHandle as suggested
> by Paul Vriens
> - Match the bad formating of the rest of the file

Avoiding a needless renaming of ID_EXECUTE to ID_RUN would make the patch
much smaller. Also avoiding useless typedef, making WineFile_OnRun() static,
using correct casts, avoiding hungarian notation and magic flags would make
the patch slightly cleaner.

-- 
Dmitry.

[PATCH] Replace builtin WineFile Execute Dialog with standard RunFileDialog

[Steven Edwards]

Hi Dmitry,

On Thu, Dec 24, 2009 at 2:21 AM, Dmitry Timoshkov
<dmitry(a)codeweavers.com> wrote:
> Avoiding a needless renaming of ID_EXECUTE to ID_RUN would make the patch
> much smaller. Also avoiding useless typedef, making WineFile_OnRun() static,
> using correct casts, avoiding hungarian notation and magic flags would make
> the patch slightly cleaner.

Thanks for the feedback. I'll clean it up per your suggestions though
I don't think that renaming ID_EXECUTE is not needless since the
dialog containing the word is gone. I think it makes it less trouble
if your doing a cursory inspection to make it more consistent.

Have a Merry Christmas!
-- 
Steven Edwards

"There is one thing stronger than all the armies in the world, and
that is an idea whose time has come." - Victor Hugo