Re: [PATCH] jscript: Implemented conditional compilation support for @if, @elif, @else and @end keywords.

[Jacek Caban]

Hi Qian,

On 09/26/14 07:17, Qian Hong wrote:
> This patch improves QQDownload on Wine. Most of parser code and
> compiler code for '@if statement' are implemented based on the Wine
> vbscript implementation of 'if statement' since Microsoft JScript
> conditional compilation '@if statement' shares similar syntax with
> vbscript 'if statement'.

Not really, @if causes conditional compilation. Your patch
unconditionally compiles everything. See my simple test on top of your
patch for what I mean.

Jacek

[PATCH] jscript: Implemented conditional compilation support for @if, @elif, @else and @end keywords.

[Qian Hong]

On Fri, Sep 26, 2014 at 6:07 PM, Jacek Caban <jacek(a)codeweavers.com> wrote:
> Not really, @if causes conditional compilation. Your patch
> unconditionally compiles everything. See my simple test on top of your
> patch for what I mean.

Wow, this makes things even more interesting...
Thanks for pointing out that!


-- 
Regards,
Qian Hong

-
http://www.codeweavers.com