Re: [PATCH 1/2] secur32: Change scan_free_handle to print an error, if the index (handle) is out of range.

[Henri Verbeet]

2009/3/24 Florian Köberle <florian(a)fkoeberle.de>:
> +    if (handle_idx < 0 || handle_idx >= schan_handle_count)

handle_idx can't be < 0 because it's unsigned. Printing an ERR if the
handle is out of range is probably ok, but I think crashing is better
than just returning NULL.

[PATCH 1/2] secur32: Change scan_free_handle to print an error, if the index (handle) is out of range.

[Florian Köberle]

> handle_idx can't be < 0 because it's unsigned. Printing an ERR if the
> handle is out of range is probably ok, but I think crashing is better
> than just returning NULL.

I hoped that you would have thought otherwise about returning null. You
might still get a crash at some point later, but the patch allows
Warcraft III users to stay in the chat room much longer then one minute.
I will make and resent an updated patch. Thanks for taking your time to
review the patches.