Re: [PATCH 2/2] winmm: MCI_BREAK_HWND handling now matches Wine's 1999 MCI_DefYieldProc.

[Alexandre Julliard]

<Joerg-Cyril.Hoehle(a)t-systems.com> writes:
> @@ -2063,9 +2063,10 @@ static	DWORD MCI_Break(UINT wDevID, DWORD dwFlags, LPMCI_BREAK_PARMS lpParms)
>      switch (dwFlags & (MCI_BREAK_KEY | MCI_BREAK_OFF)) {
>      case MCI_BREAK_KEY:
>   wmd->lpfnYieldProc = MCI_DefYieldProc;
> -	wmd->dwYieldData   = lpParms->nVirtKey;
> -	if (dwFlags & MCI_BREAK_HWND)
> -	    FIXME("(%x) vkey %02X on window %p\n", dwFlags, lpParms->nVirtKey, lpParms->hwndBreak);
> +	/* Our MCI_DefYieldProc from 1999-04-11 expects this DWORD splitting,
> +	 * yet tests on w2k-w7 prove wmd->dwYieldData = lpParms->nVirtKey; */

It doesn't make sense to add workarounds for Wine code, it should be
fixed instead.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 2/2] winmm: MCI_BREAK_HWND handling now matches Wine's 1999 MCI_DefYieldProc.

Hi,
> It doesn't make sense to add workarounds for Wine code, it should be
> fixed instead.
> That's why I had separated this debatable part into patch 2/2.

But what about patch 1/2 not yet committed? That one contains all stuff
that's not debatable and is backed up by tests from w2k-w7.
1/2 is stand-alone, despite the /2.

I'll not touch MCI_BREAK_HWND, because all of this windows messaging stuff.
Somebody else please contribute PeekMessage etc. code.

Regards,
 Jörg Höhle