Re: Spelling fixes round 6 - resend - don't apply first patch

[Francois Gouget]

#ifdef HAVE_UNISTD_H
-# include <unistd.h>
+#include <unistd.h>
 #endif
 #include <stdarg.h>
 #include <stdio.h>

I think this chunk should not be applied because:
 * as pointed out before, it's not a spelling fix
 * it's perfectly valid to have a space there
 * the indentation makes the scope of the #ifdef clearer. So removing it 
makes the code less readable


-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
     You can have my guns when you pry them from my kids cold, dead hands.

Spelling fixes round 6 - resend - don't apply first patch

[James McKenzie]

Francois Gouget wrote:
> #ifdef HAVE_UNISTD_H
> -# include <unistd.h>
> +#include <unistd.h>
>  #endif
>  #include <stdarg.h>
>  #include <stdio.h>
>
> I think this chunk should not be applied because:
>  * as pointed out before, it's not a spelling fix
>  * it's perfectly valid to have a space there
>  * the indentation makes the scope of the #ifdef clearer. So removing it 
> makes the code less readable

Francois:

I am a long time programmer and expect the include to be next to the # 
sign.  However, you are correct in that it does not break code, and if 
it is not broken, why fix?  Is it possible to indent the entire line by 
two spaces (I think it is not)?

James McKenzie

Spelling fixes round 6 - resend - don't apply first patch

[Rolf Kalbermatter]

James McKenzie:
> I am a long time programmer and expect the include to be next 
> to the # sign.  However, you are correct in that it does not 
> break code, and if it is not broken, why fix?  Is it possible 
> to indent the entire line by two spaces (I think it is not)?

Probably not. I know there are (ancient) C compilers that will bark
when the # is not the first character in a line as the preprocessor
will then not see it as a valid preprocessor line and simply ignore
it.

Rolf Kalbermatter