Re: [PATCH 1/7] dsound: Implement DSPROPERTY_WaveDeviceMappingA on top of *W

[Alexandre Julliard]

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes:
> +    data.DataFlow = ppd->DataFlow;
> +    len = strlen(ppd->DeviceName)+1;
> +    data.DeviceName = HeapAlloc(GetProcessHeap(), 0, len);
> +    if (!data.DeviceName)
> +        return E_OUTOFMEMORY;
> +    MultiByteToWideChar(CP_ACP, 0, ppd->DeviceName, -1, data.DeviceName, len );

The W length handling is broken.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 1/7] dsound: Implement DSPROPERTY_WaveDeviceMappingA on top of *W

[Maarten Lankhorst]

Hi AJ,

Alexandre Julliard schreef:
> Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes:
> > +    data.DataFlow = ppd->DataFlow;
> > +    len = strlen(ppd->DeviceName)+1;
> > +    data.DeviceName = HeapAlloc(GetProcessHeap(), 0, len);
> > +    if (!data.DeviceName)
> > +        return E_OUTOFMEMORY;
> > +    MultiByteToWideChar(CP_ACP, 0, ppd->DeviceName, -1, data.DeviceName, len );
>
> The W length handling is broken.

Yep, I wonder why valgrind didn't catch it.. sent updated version

Cheers,
Maarten