Re: [PATCH 1/2] mshtml: Implement IHTMLXMLHttpRequestFactory as a stub.

[Jacek Caban]

Hi Zhenbo,

On 06/08/15 17:04, Zhenbo Li wrote:
> --- a/dlls/mshtml/htmlwindow.c
> +++ b/dlls/mshtml/htmlwindow.c
> @@ -1965,8 +1965,23 @@ static HRESULT WINAPI HTMLWindow5_put_XMLHttpRequest(IHTMLWindow5 *iface, VARIAN
>  static HRESULT WINAPI HTMLWindow5_get_XMLHttpRequest(IHTMLWindow5 *iface, VARIANT *p)
>  {
>      HTMLWindow *This = impl_from_IHTMLWindow5(iface);
> -    FIXME("(%p)->(%p)\n", This, p);
> -    return E_NOTIMPL;
> +    HTMLInnerWindow *window = This->inner_window;
> +
> +    TRACE("(%p)->(%p)\n", This, p);
> +
> +    if(!window->xml_factory) {
> +        HRESULT hres;
> +
> +        hres = HTMLXMLHttpRequestFactory_Create(window, &window->xml_factory);
> +        if(FAILED(hres))
> +            return hres;
> +    }

This instance will be leaked. You need to release it when
HTMLInnerWindow is freed.

Cheers,
Jacek